[RFC 2/5] dt: bcm2835-mmc bindings documentation

[Lee Jones]

You need to CC LKML on all of your upstream patches.

On Wed, 29 Oct 2014, Piotr Król wrote:

> Signed-off-by: Piotr Król <piotr.krol at 3mdeb.com>
> ---
>  .../devicetree/bindings/mmc/brcm,bcm2835-mmc.txt   | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mmc/brcm,bcm2835-mmc.txt

Nothing major, just some nits.

> diff --git a/Documentation/devicetree/bindings/mmc/brcm,bcm2835-mmc.txt b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-mmc.txt
> new file mode 100644
> index 000000000000..06f0f98b03ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-mmc.txt
> @@ -0,0 +1,23 @@
> +Broadcom BCM2835 Arasan EMMC controller

s/EMMC/eMMC

> +This file documents differences between the core properties described
> +by mmc.txt and the properties that represent the BCM2835 controller.
> +
> +Required properties:

These documents always look a little better with the descriptions
tabbed out.

> +- compatible : Should be "brcm,bcm2835-mmc".
> +- clocks : The clock feeding the EMMC controller.

s/EMMC/eMMC

> +- dmas : DMA specifiers for tx and rx dma.

s/ dma//

> +- dma-names: RX and TX  DMA request names.

s/  / /

'\n' here.

> +Example:
> +
> +mmc: mmc at 7e300000 {

Is this node ever referenced by phandle?  If not, you can remove the
label.

> +		compatible = "brcm,bcm2835-mmc";
> +		reg = <0x7e300000 0x100>;
> +		interrupts = <2 30>;
> +		clocks = <&clk_mmc>;
> +		dmas = <&dma 5>,
> +		<&dma 5>;

Either put this on the line above, or tab it out level with the
previous entry.  They're the same; are they both required?

> +		dma-names = "tx", "rx";
> +		status = "disabled";

All of these properties should be single tabbed.

> +}

Missing a ';' here.