[PATCH 1/2] [GPIOLib] GPIO Interrupt counter support v2

Greg KH greg at kroah.com
Wed May 28 08:05:15 PDT 2014

On Wed, May 28, 2014 at 04:53:45PM +0200, Federico Fuga wrote:
> Ok, I'll fix the tagline.
> Il giorno 28/mag/2014, alle ore 16:34, Greg KH <greg at kroah.com> ha scritto:
> >> +	unsigned long    counter;    /* IRQ Events counter */
> >> +#endif
> > 
> > Why #ifdef this?  Is it so big that it can't just always be in the
> > structure?  In fact, why not always keep track of this and only export
> > it if needed?  Or why not always just export it, no need for a config
> > option at all, who would want to turn it off?
> > 
> I don't know, just leaving the freedom to choose. what do you suggest?

I suggest just enabling it, the proliferation of config options is an
issue, especially as you aren't giving a reason why this should be
disabled (or enabled for that matter...)

Also realize that you will have to run this by the gpio developers, why
are you not cc: them as well?


greg k-h

More information about the linux-rpi-kernel mailing list