[PATCH 1/2] [GPIOLib] GPIO Interrupt counter support v2
fuga at studiofuga.com
Wed May 28 07:49:21 PDT 2014
Hi Greg, thanks for your comments.
Il giorno 28/mag/2014, alle ore 16:35, Greg KH <greg at kroah.com> ha scritto:
>> + return ret;
>> +int gpio_counter_set(unsigned gpio, long value)
>> + struct gpio_desc *desc = gpio_to_desc(gpio);
>> + mutex_lock(&sysfs_lock);
>> + desc->counter = value;
>> + mutex_unlock(&sysfs_lock);
>> + return 0;
> Who uses these get/set functions? If no one is using them, please don't
> provide them, we don't add apis with no users in the kernel. Or if you
> do, someone else will come along and rip them out, which is wasteful of
> time and developer resources...
Sure, you're right, but I thought it may be useful to some platform driver.
Anyway I'll follow your hint.
> greg k-h
More information about the linux-rpi-kernel