[PATCH v3] pinctrl: Pass all configs to driver on pin_config_set()

Sherman Yin syin at broadcom.com
Tue Aug 27 14:22:31 EDT 2013


Hi Laurent,

>> diff --git a/drivers/pinctrl/sh-pfc/pinctrl.c
>> b/drivers/pinctrl/sh-pfc/pinctrl.c index 8649ec3..ced199e 100644
>> --- a/drivers/pinctrl/sh-pfc/pinctrl.c
>> +++ b/drivers/pinctrl/sh-pfc/pinctrl.c
>> @@ -529,38 +529,44 @@ static int sh_pfc_pinconf_get(struct pinctrl_dev
>> *pctldev, unsigned _pin, }
>>
>>  static int sh_pfc_pinconf_set(struct pinctrl_dev *pctldev, unsigned _pin,
>> -			      unsigned long config)
>> +			      unsigned long *configs, unsigned num_configs)
>>  {
>>  	struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
>>  	struct sh_pfc *pfc = pmx->pfc;
>> -	enum pin_config_param param = pinconf_to_config_param(config);
>> +	enum pin_config_param param;
>>  	unsigned long flags;
>> +	int i;
>
>Could you please make this an unsigned int ?
>
>Other than that the sh-pfc part looks good to me.
 
Thanks for the review.  I'll make this change.  Can I add you as a 
Reviewed-by?

I just realized I didn't include the linux-arm-kernel maillist in my v3 patch, so 
I'll make this change send out a v4.  

Regards,
Sherman




More information about the linux-rpi-kernel mailing list