[U-Boot] [PATCH 1/2] mmc: add bcm2835 driver

Stephen Warren swarren at wwwdotorg.org
Fri Oct 26 14:21:13 EDT 2012

On 10/26/2012 12:05 PM, Tom Rini wrote:
> On 10/26/12 10:48, Oleksandr Tymoshenko wrote:
>> On 10/26/2012 10:32 AM, Tom Rini wrote:
>>> On Tue, Oct 23, 2012 at 10:50:47PM -0600, Stephen Warren
>>> wrote:
>>>> This adds a simple driver for the BCM2835's SD controller.
>>>> Workarounds are implemented for: * Register writes can't be
>>>> too close to each-other in time, or they will be lost. *
>>>> Register accesses must all be 32-bit, so implement custom
>>>> accessors.
>>>> This code was extracted from: 
>>>> git://github.com/gonzoua/u-boot-pi.git master which was
>>>> created by Oleksandr Tymoshenko.
>>>> Portions of the code there were obviously based on the Linux 
>>>> kernel at: git://github.com/raspberrypi/linux.git rpi-3.2.27
>>>> No s-o-b tags were present in either location.
>>> Um, that's a bit worrying to me.  Wolfgang?
>> I didn't have much experience with s-o-b stuff, so excuse my 
>> ignorance. Is there official procedure, or is it enough to state 
>> that I sign off on everything in 
>> git://github.com/gonzoua/u-boot-pi.git master authored by me?
> Just about.  Please read 
> http://elinux.org/Developer_Certificate_Of_Origin and then
> assuming that is all true, reply to this email with a properly
> formatted Signed-off-by line (and then hey, you end up in the
> contributors for the next U-Boot release, once the code is merged).
> And then you can get in the habit of doing 'git commit -s' for
> projects where the above applies.  There's still a question about
> the portions taken from the kernel tree.  Thanks!

Although do remember that U-Boot uses S-o-b differently to how the Linux
kernel uses it, based on our recent discussions. For U-Boot, it's
apparently only about original authorship and/or changes to the
patches, whereas for the kernel, people who handle the patch without
changes (i.e. apply it to a git tree) also sign the patch off.

Equally, since this code was derived from Linux kernel source, we should
track down who wrote that and get them to sign it off too.

More information about the linux-rpi-kernel mailing list