[PATCH 3/7] bcm2835-rpi: add compatible properties for SPI to work with pinconf

Chris Boot bootc at bootc.net
Tue May 29 13:28:09 EDT 2012

On 29/05/12 03:30, Stephen Warren wrote:
> On 05/28/2012 01:02 AM, Chris Boot wrote:
>> On 28/05/12 07:12, Stephen Warren wrote:
>>> On 05/26/2012 03:19 PM, Chris Boot wrote:
>>>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi
>>>> b/arch/arm/boot/dts/bcm2835.dtsi
>>>> -            compatible = "broadcom,bcm2835-spi",
>>>> "broadcom,bcm2708-spi";
>>>> +            compatible = "broadcom,bcm2835-spi",
>>>> "broadcom,bcm2708-spi", "broadcom,bcm2835-pinctrl-device",
>>>> "broadcom,bcm2708-pinctrl-device";
>>> This shouldn't be needed at all; devices don't need to declare
>>> themselves as being a pinctrl user in their own compatible flags.
>>> If this change were needed, it should occur before the previous patch to
>>> convert the SPI driver to use pinctrl, so that everything needed by
>>> pinctrl is available in the device tree before the driver attempts to
>>> use it, otherwise someone checking out the code at the previous patch
>>> would find it doesn't work - that will break "git bisect".
>> This is a side-effect of Simon's pinctrl driver. I guess we need to find
>> a better/different way of getting the driver to notice this device to
>> set up the default pinctrl mappings through device tree.
> You might want to look at (and potentially backport) the new
> standardized pinctrl bindings that are (I think now have been) merged
> into 3.5 (if not yet, see linux-next).
> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt hopefully
> describes it well.

Aha, I've just seen this. Looks like it is indeed part of Linus's tree 
now, so I'll take a look at moving our pinctrl stuff to that - or more 
likely prod Simon! ;-)


Chris Boot
bootc at bootc.net

More information about the linux-rpi-kernel mailing list