[PATCH 3/7] bcm2835-rpi: add compatible properties for SPI to work with pinconf

Stephen Warren swarren at wwwdotorg.org
Mon May 28 02:12:41 EDT 2012

On 05/26/2012 03:19 PM, Chris Boot wrote:
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi

> -			compatible = "broadcom,bcm2835-spi", "broadcom,bcm2708-spi";
> +			compatible = "broadcom,bcm2835-spi", "broadcom,bcm2708-spi", "broadcom,bcm2835-pinctrl-device", "broadcom,bcm2708-pinctrl-device";

This shouldn't be needed at all; devices don't need to declare
themselves as being a pinctrl user in their own compatible flags.

If this change were needed, it should occur before the previous patch to
convert the SPI driver to use pinctrl, so that everything needed by
pinctrl is available in the device tree before the driver attempts to
use it, otherwise someone checking out the code at the previous patch
would find it doesn't work - that will break "git bisect".

More information about the linux-rpi-kernel mailing list