[PATCH v5 11/21] drm/bridge: inno-hdmi: Add .mode_valid platform operation
Heiko Stübner
heiko at sntech.de
Wed Sep 30 03:19:15 PDT 2026
Am Dienstag, 29. September 2026, 12:31:08 Mitteleuropäische Sommerzeit schrieb Michal Wilczynski:
> inno_hdmi_bridge_mode_valid() validates the pixel clock against
> hdmi->refclk, but that clock is optional and is only present on
> platforms that describe a "ref" clock. Platforms where the pixel clock
> is produced by a separate device - such as the StarFive JH7110, whose
> PHY is both the clock and the PHY provider - have no "ref" clock, so
> the check is skipped entirely and every mode is reported as valid.
>
> A mode the platform cannot generate is then advertised to userspace.
> The subsequent modeset appears to succeed, since the atomic enable path
> cannot fail, and the display silently stays blank.
>
> Add a .mode_valid platform operation so platforms can reject modes they
> are unable to drive. Platforms that do not implement it are unaffected.
>
> Reviewed-by: Joshua Peisach <jpeisach at ubuntu.com>
> Signed-off-by: Michal Wilczynski <m.wilczynski at samsung.com>
In patch 19 you add the jh7110-inno-hdmi-phy variant of the phy which
registers a clock provider for the pixel clock. Isn't that the refclk you're
missing?
Thanks
Heiko
More information about the Linux-rockchip
mailing list