[PATCH net v2] net: pcs: xpcs: make supported_interfaces authoritative

Andrew Lunn andrew at lunn.ch
Thu Oct 29 06:10:31 PDT 2026


> +	/*
> +	 * The RK3568 XPCS supports 1000BASE-X, SGMII and QSGMII.
> +	 */
> +	phy_interface_zero(xpcs->pcs.supported_interfaces);
> +	__set_bit(PHY_INTERFACE_MODE_SGMII, xpcs->pcs.supported_interfaces);

The comment and the code does not really match. Why not set the other
two interface modes as well?

    Andrew



More information about the Linux-rockchip mailing list