[PATCH 4/5] dt-bindings: power: supply: rk817-charger: Add rockchip,gate-function-disable

[Krzysztof Kozlowski]

On Tue, Oct 27, 2026 at 10:53:10AM -0500, Chris Morgan wrote:
> On Mon, Oct 26, 2026 at 08:23:40PM +0100, Heiko Stübner wrote:
> > Hi Chris,
> > 
> > Am Montag, 26. Oktober 2026, 18:48:33 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> > > From: Chris Morgan <macromorgan at hotmail.com>
> > > 
> > > Add a boolean attribute for the rk817-charger to control whether or not
> > > the system power is shutdown in battery off mode. The BSP kernel sets
> > > this value unless a device-tree attribute is present, and this attribute
> > > is to replicate that behavior.
> > 
> > Devicetree is supposed to describe the hardware, so your description needs
> > to describe the per-board property this represents.
> > 
> > Just because it's in a vendor-BSP is generally not enough justification :-) .
> > 
> > This is especially true as you wrote in the cover-letter that no known
> > board actually needs this right now.
> > 
> > 
> > Heiko
> 
> The datasheet describes this as "Whether the system voltage can be
> shutdown in Bat_off mode" and the register itself is described as
> SYS_CAN_SD. Maybe call it "rockchip,can-shutdown-bat-off"? Or given the
> fact that I'm not aware of any boards that would need it today, should

Why would you like to add dead code?

Anyway, describe what problem is with the hardware that such property is
needed.

Best regards,
Krzysztof