[PATCH 0/4] Suspend-to-RAM fixes for RK3588 + SPI-connected RK806 PMIC, enable PMIC sleep on RK3588 Tiger

Jakob Unterwurzacher jakob.unterwurzacher at cherry.de
Thu Nov 19 01:12:49 PST 2026


Hi Quentin, thanks for looking at this!

On 10/29/26 20:31, Quentin Schulz wrote:
> Hi Jakob,
> 
> On 10/29/26 11:06 AM, Jakob Unterwurzacher wrote:
>> This series, together with a few out-of-tree patches (see below), makes
>> suspend-to-RAM on RK3588-Tiger work, down to a power consumption of
>> about 0.4 W. Patches 1-3 apply to all boards with an RK806 PMIC
>> connected via SPI, which includes most RK3588 boards.
>>
>> Patch 1 ("Input: rk805-pwrkey - enable the wakeup interrupt during 
>> system suspend")
>> arms the power key interrupt as a wakeup source, so that the
>> power key can wake up the system. This is done in the regular suspend
>> phase, because the SPI bus to the PMIC can no longer be used in the
>> noirq phase.
>>
>> Patch 2 ("mfd: rk8xx-core: keep the PMIC interrupt disabled during 
>> system suspend")
>> keeps the PMIC interrupt disabled across system suspend, so that its
>> handler does not run before the bus to the PMIC has resumed.
>>
>> Patch 3 ("mfd: rk8xx-spi: add system sleep PM ops")
>> hooks up the existing rk8xx suspend/resume callbacks for the SPI
>> variant, which so far lacked them.
>>
>> Patch 4 ("arm64: dts: rockchip: put the PMIC into sleep mode in 
>> suspend on RK3588 Tiger")
>> configures the RK806 PWRCTRL1 pin on RK3588 Tiger for its sleep
>> function, so that the regulator suspend states take effect. This lowers
>> the module's power consumption in suspend-to-RAM from 1.09 W to 0.43 W.
>>
>> The patches do not depend on each other and can be applied through
>> their respective trees.
>>
> 
> Then have them in separate series. Series should be as small as 
> possible, down to a single commit if possible.


I'll split it into tree (1, 2+3, 4).


>> 1) Upstream TF-A does not complete suspend-to-RAM on this board yet, 
>> so the
>> tests used Rockchip's BL31 (rkbin v1.47), configured through a small
>> out-of-tree driver. The plan is to get suspend working in TF-A instead.
>>
> 
> I'm guessing you(r LLM) meant upstream TF-A here? Or what is it that you 
> mean?

Yes, both my LLM and me meant upstream TF-A.

>> 2) The inno-usb2 PHY has to be resumed when its 480 MHz clock is enabled,
>> otherwise EHCI/OHCI resume hangs. This is addressed by Sebastian
>> Reichel's inno-usb2 series [1].
>>
> 
> Having access to your downstream branch, you have a patch generated by 
> your LLM and not Sebastian's patch series. Either use what Sebastian 
> posted, or be more careful in your choice of words as I read the above 
> as implying you used his series.

I have now pulled in Sebastian's patch series instead and posted a 
Tested-By ( 
https://lore.kernel.org/lkml/ae532396-557b-4a0b-b13c-920a971962b8@cherry.de/ 
).

>> Known issues
>> ------------
>>
>> PCIe devices do not survive resume; this depends on system PM
>> support in pcie-dw-rockchip [2].
>>
>> [2] https://eur02.safelinks.protection.outlook.com/? 
>> url=https%3A%2F%2Flore.kernel.org%2Fr%2F20260316-rockchip-pcie-system- 
>> suspend- 
>> v5-0-5bb5ad37d643%40collabora.com&data=05%7C02%7Cjakob.unterwurzacher%40cherry.de%7C464ac9f060054aad6eb808df35f33f19%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C639288990982194241%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=cg2d38YMtjlOG4gFsyy7LYI%2FWi4RFRUuHL8QjVL0DJg%3D&reserved=0
>>
> 
> There already is a v6 from almost two months ago. Did you actually test 
> with the v5 or are you just hinting at what could be helping resume PCIe 
> devices?
> 
> I'm sure Sebastian would be happy to receive a nice Tested-by tag if you 
> did indeed test that.

I was just hinting.

It was merged in the meantime ( 
https://lore.kernel.org/linux-pci/179407115382.87267.12160393716568806842.b4-ty@b4/ 
) and I have now also pulled it into my local tree. It solves the problem.

> All your patches are missing the Signed-off-by, required to signify 
> DCO[1]. LLMs are forbidden to add it, so I guess you missed that when 
> reviewing the patches before sending. Please triple check that you agree 
> to all criteria listed in the documentation before adding the SoB to 
> patches generated by LLMs[2].
Well, that's embarrassing.

"b4 prep --check" came back clean, so I assumed that b4 adds the 
Signed-off-by.

But, as it turns out, "b4 prep --check" does not actually work.
I have reported this as 
https://lore.kernel.org/all/a37b228f-0d12-4c26-b29b-51ad59bc6d1a@cherry.de/ 
.

Thanks for the links, I have triple-checked.

Best regards,
Jakob



More information about the Linux-rockchip mailing list