[PATCH v3 2/8] drm/rockchip: vop2: Don't use uninitialised dividers on RK3588
Damon Ding
damon.ding at rock-chips.com
Tue Nov 17 23:55:44 PST 2026
On 11/14/2026 12:39 AM, Arun Iyengar via B4 Relay wrote:
> From: Arun Iyengar <aiyengar1990 at gmail.com>
>
> rk3588_calc_cru_cfg() converts all four dividers with ilog2(), but every
> interface only sets the ones it uses: dclk_out_div is left uninitialised
> for HDMI, eDP and DPI, if_dclk_div for DP, MIPI and DPI, and
> if_pixclk_div for DP and DPI. For HDMI and eDP the uninitialised
> dclk_out_div is then written to RK3588_VP_CLK_CTRL.
>
> Set the dividers an interface doesn't use to 1.
>
> Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588")
> Suggested-by: Damon Ding <damon.ding at rock-chips.com>
> Signed-off-by: Arun Iyengar <aiyengar1990 at gmail.com>
> ---
> drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> index c44648e1bc0d..f340aba5bfd1 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
> @@ -1597,6 +1597,7 @@ static unsigned long rk3588_calc_cru_cfg(struct vop2_video_port *vp, int id,
> */
> *if_pixclk_div = 2;
> *if_dclk_div = 4;
> + *dclk_out_div = 1;
> } else if (vop2_output_if_is_edp(id)) {
> /*
> * edp_pixclk = edp_dclk > dclk_core
> @@ -1609,6 +1610,7 @@ static unsigned long rk3588_calc_cru_cfg(struct vop2_video_port *vp, int id,
> */
> *if_pixclk_div = K;
> *if_dclk_div = K;
> + *dclk_out_div = 1;
> } else if (vop2_output_if_is_dp(id)) {
> if (output_mode == ROCKCHIP_OUT_MODE_YUV420)
> dclk_out_rate = v_pixclk >> 3;
> @@ -1622,6 +1624,8 @@ static unsigned long rk3588_calc_cru_cfg(struct vop2_video_port *vp, int id,
> return 0;
> }
> *dclk_out_div = dclk_rate / dclk_out_rate;
> + *if_pixclk_div = 1;
> + *if_dclk_div = 1;
> } else if (vop2_output_if_is_mipi(id)) {
> if_pixclk_rate = dclk_core_rate / K;
> /*
> @@ -1643,8 +1647,12 @@ static unsigned long rk3588_calc_cru_cfg(struct vop2_video_port *vp, int id,
> * mipi pixclk == dclk_out
> */
> *if_pixclk_div = 1;
> + *if_dclk_div = 1;
> } else if (vop2_output_if_is_dpi(id)) {
> dclk_rate = v_pixclk;
> + *dclk_out_div = 1;
> + *if_pixclk_div = 1;
> + *if_dclk_div = 1;
> }
>
> *dclk_core_div = dclk_rate / dclk_core_rate;
>
Reviewed-by: Damon Ding <damon.ding at rock-chips.com>
Best regards,
Damon
More information about the Linux-rockchip
mailing list