[PATCH v2 2/2] PM: runtime: fix stub pm_runtime_get_if_in_use() for !CONFIG_PM

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Nov 16 07:52:11 PST 2026


On Mon, Nov 16, 2026 at 09:43:13AM -0600, Frank Li wrote:
> On Mon, Nov 16, 2026 at 05:31:39PM +0200, Laurent Pinchart wrote:
> > On Mon, Nov 16, 2026 at 10:25:11AM -0500, Frank.Li at oss.nxp.com wrote:
> > > From: Frank Li <Frank.Li at nxp.com>
> > >
> > > The stub for pm_runtime_get_if_in_use() under !CONFIG_PM currently
> > > returns -EINVAL.  The real implementation returns:
> > >   1  - device is active and its usage counter is non-zero (bumped)
> > >   0  - device is not in use or not active (counter not bumped)
> > >  -EINVAL - runtime PM disabled for this device
> > >
> > > When CONFIG_PM is not set every device is permanently "active" and
> > > always considered "in use", so the stub must return 1, mirroring
> > > __pm_runtime_resume() which already returns 1 in the same build.
> > >
> > > Returning -EINVAL breaks callers that test the return value with
> > > comparisons other than "!= 0 / == 0":
> > >
> > > drivers/gpu/drm/i915/intel_runtime_pm.c:
> > >   if (intel_runtime_pm_get_if_in_use(rpm))
> > >   which wraps to: ret = pm_runtime_get_if_in_use(); return ret > 0;
> > >   With -EINVAL the wrapper returns false, causing an incorrect error
> > >   path in the GT fence revocation code.
> > >
> > > drivers/gpu/drm/xe/xe_pm.c:
> > >   if (pm_runtime_get_if_in_use(xe->drm.dev) > 0)
> > >   With -EINVAL the condition is false; xe_pm_runtime_get_if_in_use()
> > >   returns false, so callers believe the device is not usable.
> > >
> > > drivers/gpu/drm/gma500/power.c:
> > >   return pm_runtime_get_if_in_use(dev) == 1;
> > >   -EINVAL != 1, so the helper always returns false when !CONFIG_PM.
> > >
> > > drivers/gpu/drm/imagination/pvr_power.c:
> > >   if (pm_runtime_get_if_in_use(...) <= 0)
> > >   -EINVAL <= 0 is true, so the driver always takes the "requeue" error
> > >   path instead of proceeding with the active device.
> > >
> > > sound/soc/sof/debug.c:
> > >   if (pm_runtime_get_if_in_use(sdev->dev) == 1)
> > >   -EINVAL != 1, so d3_prevented is never set, corrupting exception
> > >   debug accounting.
> > >
> > > drivers/iommu/mtk_iommu.c:
> > >   if (pm_runtime_get_if_in_use(dom->plat_dev->dev) <= 0)
> > >   -EINVAL <= 0 skips the TLB flush, leaving stale IOMMU mappings.
> > >
> > > drivers/iommu/rockchip-iommu.c:
> > >   Three call sites use WARN_ON_ONCE(err < 0) or similar patterns.
> > >   -EINVAL < 0 triggers a spurious WARNING on every call.
> > >
> > > drivers/media/i2c/isl7998x.c:
> > >   if (pm_runtime_get_if_in_use(dev) <= 0)  (two call sites)
> > >   -EINVAL <= 0 causes the driver to always skip register programming
> > >   when !CONFIG_PM.
> > >
> > > drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c:
> > >   if (pm_runtime_get_if_in_use(dev) <= 0)  (two call sites)
> > >   -EINVAL <= 0 prevents any debug statistics from being collected.
> > >
> > > Fixes: 9d58aa46291d ("drm/i915: Fix the GT fence revocation runtime PM logic")
> > > Fixes: cbb6a7413b17 ("drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers")
> > > Fixes: 672c473576ca ("drm/gma500: Rewrite power management code")
> > > Fixes: 727538a4bbff ("drm/imagination: Implement power management")
> > > Fixes: b30289e7fa92 ("ASoC: SOF: Fix runtime pm usage counter balance after fw exception")
> > > Fixes: c0b57581b73b ("iommu/mediatek: Add power-domain operation")
> > > Fixes: 0f181d3cf7d9 ("iommu/rockchip: Add runtime PM support")
> > > Fixes: 51ef2be546e2 ("media: i2c: isl7998x: Add driver for Intersil ISL7998x")
> > > Fixes: cbb819c363c5 ("media: rkisp1: debug: Collect input status by sampling ISP_FLAGS_SHD")
> >
> > I don't think this one is right. The rkisp1 driver only runs on ARCH_MXC
> > and ARCH_ROCKCHIP, which select CONFIG_PM. The same may be true for some
> > of the other fixes tags.
> 
> But code itself should be wrong even though these platform force enable
> CONFIG_PM.

How does it make the code wrong in the rkisp1 driver ? There's nothing
to fix there, because there's no bug.

I'm not saying this patch is wrong (I'll let the runtime PM folks
provide expert feedback), but I think some of the Fixes: tags are not
correct.

> > > Signed-off-by: Frank Li <Frank.Li at nxp.com>
> > > ---
> > > Change in v2
> > > - new patches.
> > >
> > > Cc: "Rafael J. Wysocki" <rafael at kernel.org>
> > > Cc: linux-pm at vger.kernel.org
> > > Cc: Jani Nikula <jani.nikula at linux.intel.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > > Cc: Tvrtko Ursulin <tursulin at ursulin.net>
> > > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > > Cc: Maxime Ripard <mripard at kernel.org>
> > > Cc: "Thomas Hellstrom" <thomas.hellstrom at linux.intel.com>
> > > Cc: Simona Vetter <simona at ffwll.ch>
> > > Cc: David Airlie <airlied at gmail.com>
> > > Cc: Matthew Brost <matthew.brost at intel.com>
> > > Cc: Thomas Zimmermann <tzimmermann at suse.de>
> > > Cc: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>
> > > Cc: Alessio Belle <alessio.belle at imgtec.com>
> > > Cc: Luigi Santivetti <luigi.santivetti at imgtec.com>
> > > Cc: Liam Girdwood <lgirdwood at gmail.com>
> > > Cc: Mark Brown <broonie at kernel.org>
> > > Cc: Jaroslav Kysela <perex at perex.cz>
> > > Cc: Takashi Iwai <tiwai at suse.com>
> > > Cc: Bard Liao <yung-chuan.liao at linux.intel.com>
> > > Cc: Pierre-Louis Bossart <pierre-louis.bossart at linux.dev>
> > > Cc: Peter Ujfalusi <peter.ujfalusi at linux.intel.com>
> > > Cc: Kai Vehmanen <kai.vehmanen at linux.intel.com>
> > > Cc: Robin Murphy <robin.murphy at arm.com>
> > > Cc: Yong Wu <yong.wu at mediatek.com>
> > > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> > > Cc: Matthias Brugger <matthias.bgg at gmail.com>
> > > Cc: Heiko Stuebner <heiko at sntech.de>
> > > Cc: Mauro Carvalho Chehab <mchehab at kernel.org>
> > > Cc: Dafna Hirschfeld <dafna at fastmail.com>
> > > Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > Cc: Michael Tretter <m.tretter at pengutronix.de>
> > > Cc: Daniel Baluta <daniel.baluta at nxp.com>
> > > Cc: Will Deacon <will at kernel.org>
> > > Cc: Vijendar Mukunda <Vijendar.Mukunda at amd.com>
> > > Cc: dri-devel at lists.freedesktop.org
> > > Cc: imagination at lists.freedesktop.org
> > > Cc: intel-gfx at lists.freedesktop.org
> > > Cc: intel-xe at lists.freedesktop.org
> > > Cc: iommu at lists.linux.dev
> > > Cc: linux-arm-kernel at lists.infradead.org
> > > Cc: linux-mediatek at lists.infradead.org
> > > Cc: linux-media at vger.kernel.org
> > > Cc: linux-rockchip at lists.infradead.org
> > > Cc: linux-sound at vger.kernel.org
> > > Cc: sound-open-firmware at alsa-project.org
> > > Cc: imx at lists.linux.dev
> > > ---
> > >  include/linux/pm_runtime.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
> > > index de9e7518ecef2..1d983fe55a16a 100644
> > > --- a/include/linux/pm_runtime.h
> > > +++ b/include/linux/pm_runtime.h
> > > @@ -276,7 +276,7 @@ static inline int pm_schedule_suspend(struct device *dev, unsigned int delay)
> > >  }
> > >  static inline int pm_runtime_get_if_in_use(struct device *dev)
> > >  {
> > > -	return -EINVAL;
> > > +	return 1;
> > >  }
> > >  static inline int pm_runtime_get_if_active(struct device *dev)
> > >  {

-- 
Regards,

Laurent Pinchart



More information about the Linux-rockchip mailing list