[PATCH v1 1/2] media: rockchip: rkcif: Don't reset the hardware in runtime suspend
Mehdi Djait
mehdi.djait at linux.intel.com
Mon Nov 16 06:30:19 PST 2026
Hi Michael,
On Mon, Nov 16, 2026 at 11:58:35AM +0100, Michael Riesch wrote:
> Hi Mehdi,
>
> On 11/12/26 19:32, Mehdi Djait wrote:
> > The reset in the runtime suspend also resets the VICAP IOMMU.
> >
> > When the IOMMU driver accesses the IOMMU registers inside the delay window
> > between the assert and deassert, e.g. in rk_iommu_zap_lines() to shootdown
> > IOTLB entries, the system hangs.
> >
> > Drop the reset and the now unused reset control.
>
> I agree that the current situation is nothing more than a crude hack
> that happened to work in most cases. But I doubt simply removing the
> reset is the correct solution. Recently, I saw some downstream patch
> that makes the reset a shared one, which seems like the right thing to
> do here. What would you think about that?
Do you have a link for these patches ?
I also agree that this patch will not be the solution that will go in
but the situation needs to change.
The VICAP_GLB_CTRL register does expose this:
reset the VICAP(except MMU/AXI MASTER/REG FILE)
The Rockchip-bsp kernel exports the disable and enable functions of the
iommu driver and calls them in the rkcif driver, see:
https://github.com/rockchip-linux/kernel/blob/develop-6.1/drivers/media/platform/rockchip/cif/capture.c#L7269
--
Kind regards
Mehdi Djait
More information about the Linux-rockchip
mailing list