[PATCH 04/12] drm/atomic: Highlight that bypass commits need care
Ville Syrjala
ville.syrjala at linux.intel.com
Mon Nov 16 01:11:22 PST 2026
From: Ville Syrjälä <ville.syrjala at linux.intel.com>
Document the fact that implementing bypass commits
need actual care and attention to make sure the
effective commit reordering is actually safe.
Cc: amd-gfx at lists.freedesktop.org
Cc: André Almeida <andrealmeid at igalia.com>
Cc: Boris Brezillon <bbrezillon at kernel.org>
Cc: Christopher Snowhill <chris at kode54.net>
Cc: Dave Stevenson <dave.stevenson at raspberrypi.com>
Cc: Dharma Balasubiramani <dharma.b at microchip.com>
Cc: Dmitry Baryshkov <lumag at kernel.org>
Cc: freedreno at lists.freedesktop.org
Cc: Gustavo Padovan <gustavo.padovan at collabora.com>
Cc: Huacai Chen <chenhuacai at kernel.org>
Cc: Icenowy Zheng <zhengxingda at iscas.ac.cn>
Cc: intel-gfx at lists.freedesktop.org
Cc: intel-xe at lists.freedesktop.org
Cc: Jianmin Lv <lvjianmin at loongson.cn>
Cc: linux-arm-msm at vger.kernel.org
Cc: linux-mediatek at lists.infradead.org
Cc: linux-rockchip at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
Cc: Liviu Dudau <liviu.dudau at arm.com>
Cc: Maíra Canal <mcanal at igalia.com>
Cc: Manikandan Muralidharan <manikandan.m at microchip.com>
Cc: Maxime Ripard <mripard at kernel.org>
Cc: Mingcong Bai <jeffbai at aosc.io>
Cc: nouveau at lists.freedesktop.org
Cc: Qianhai Wu <wuqianhai at loongson.cn>
Cc: Raspberry Pi Kernel Maintenance <kernel-list at raspberrypi.com>
Cc: Simon Ser <contact at emersion.fr>
Cc: wayland-devel at lists.freedesktop.org
Cc: Xaver Hugl <xaver.hugl at kde.org>
Cc: Xi Ruoyao <xry111 at xry111.site>
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
include/drm/drm_modeset_helper_vtables.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
index d28d8ffc66b4..1036744b9922 100644
--- a/include/drm/drm_modeset_helper_vtables.h
+++ b/include/drm/drm_modeset_helper_vtables.h
@@ -1430,6 +1430,12 @@ struct drm_plane_helper_funcs {
* given update can be committed bypassing the atomic commit machinery.
* That is, if it can jump ahead of the state currently queued for update.
*
+ * Extreme care is needed to make this safe as the already queued commits
+ * will not be aware of the bypass commit that overtook them. And the
+ * state that the bypass commit will observe is the final already queued
+ * state, not the current state at the point when the bypass commit
+ * will actually execute.
+ *
* This function is also abused by drm_atomic_set_property() to determine
* if the plane can be flipped in async. The flip flag is used to
* distinguish if the function is used for just the plane state or for a
--
2.56.0
More information about the Linux-rockchip
mailing list