[PATCH v2] PM / devfreq: governor_userspace: Guard against NULL governor_data during switch
Finley Xiao
finley.xiao at rock-chips.com
Sun Nov 15 17:46:53 PST 2026
Hi Chanwoo,
Thanks for the review. You're right — I've also taken devfreq->lock
around the governor_data assignment in userspace_init() in v3.
Will send v3 shortly.
在 2026/11/14 22:16, Choi Chanwoo 写道:
>
> On 10/22/2026 11:21 AM, Finley Xiao wrote:
>> The userspace governor is the only one that uses devfreq->governor_data,
>> allocated in its DEVFREQ_GOV_START handler (userspace_init()) and freed
>> in its DEVFREQ_GOV_STOP handler (userspace_exit()).
>>
>> When switching governors via sysfs (governor_store in devfreq.c), the
>> sequence is:
>>
>> STOP(old) -> df->governor = userspace -> START(userspace) -> userspace_init
>>
>> Between the df->governor assignment and userspace_init() completing,
>> governor_data is still NULL (the previous governor never touched it,
>> and the core does not clear or pre-allocate it). During that window,
>> asynchronous paths that call update_devfreq() outside of the driver's
>> control -- the OPP notifier (devfreq.c:686) and the pm_qos notifier
>> (devfreq.c:707) -- run devfreq_update_target() under df->lock and reach
>> devfreq_userspace_func(), which dereferences governor_data without a
>> NULL check, causing:
>>
>> Unable to handle kernel access to user memory outside uaccess routines
>> pc : devfreq_userspace_func+0xc/0x28
>> lr : devfreq_update_target+0x58/0x158
>>
>> Add a NULL check in devfreq_userspace_func() and fall back to
>> previous_freq, which is the same behaviour as the existing "no user
>> frequency specified yet" branch. This closes the race for all callers
>> since every path ultimately goes through get_target_freq.
>>
>> Additionally, take devfreq->lock around the kfree()/NULL assignment in
>> userspace_exit(). Without it, a concurrent OPP/pm_qos notifier running
>> under devfreq->lock could read governor_data after it is freed but
>> before it is set to NULL, constituting a use-after-free.
>>
>> Fixes: 5fdded844892 ("PM/devfreq: governor: Add a private governor_data for governor")
>> Cc: stable at vger.kernel.org
>> Signed-off-by: Finley Xiao <finley.xiao at rock-chips.com>
>>
>> Link: https://lore.kernel.org/linux-pm/20260723080806.1451-1-finley.xiao@rock-chips.com/
>> ---
>> Changes in v2:
>> - Add Fixes: tag and Cc: stable at vger.kernel.org
>>
>> drivers/devfreq/governor_userspace.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
>> index 3906ebedbae8..f7a485c43fd7 100644
>> --- a/drivers/devfreq/governor_userspace.c
>> +++ b/drivers/devfreq/governor_userspace.c
>> @@ -24,7 +24,7 @@ static int devfreq_userspace_func(struct devfreq *df, unsigned long *freq)
>> {
>> struct userspace_data *data = df->governor_data;
>>
>> - if (data->valid)
>> + if (data && data->valid)
>> *freq = data->user_frequency;
>> else
>> *freq = df->previous_freq; /* No user freq specified yet */
>> @@ -110,8 +110,10 @@ static void userspace_exit(struct devfreq *devfreq)
>> if (devfreq->dev.kobj.sd)
>> sysfs_remove_group(&devfreq->dev.kobj, &dev_attr_group);
>>
>> + mutex_lock(&devfreq->lock);
>> kfree(devfreq->governor_data);
>> devfreq->governor_data = NULL;
>> + mutex_unlock(&devfreq->lock);
>> }
>>
>> static int devfreq_userspace_handler(struct devfreq *devfreq,
> Hi,
>
> Looks good to me.
>
> I think that it is needed to lock on usrespace_init.
>
> diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
> index f7a485c43fd7..cfbd72892598 100644
> --- a/drivers/devfreq/governor_userspace.c
> +++ b/drivers/devfreq/governor_userspace.c
> @@ -94,7 +94,9 @@ static int userspace_init(struct devfreq *devfreq)
> goto out;
> }
> data->valid = false;
> + mutex_lock(&devfreq->lock);
> devfreq->governor_data = data;
> + mutex_unlock(&devfreq->lock);
>
> err = sysfs_create_group(&devfreq->dev.kobj, &dev_attr_group);
> out:
--
Best regards,
底层平台中心 肖锋(Finley Xiao)
************************************************************************************
瑞芯微电子股份有限公司
Rockchip Electronics Co., Ltd.
福建省福州市铜盘路软件大道89号软件园A区21号楼 350003
No.21 Building, A District, Fuzhou Software Park, Fuzhou, Fujian 350003, P.R. China
Tel: 0591-83991906-8602 Mobile: 18506057603
************************************************************************************
More information about the Linux-rockchip
mailing list