[PATCH v3 5/6] arm64: dts: rockchip: fix USB OTG power on Photonicat in battery mode
Coia Prant
coiaprant at gmail.com
Tue Nov 10 08:11:35 PST 2026
Chukun Pan <amadeus at jmu.edu.cn> 于2026年11月6日周五 19:51写道:
>
> Hi,
>
> > (5V_BOOST and 5V_OUT). Adding a `vcc` prefix would break the 1:1
> > mapping between the DTS and the schematic, making it harder for
> > anyone tracing the board power.
>
> I didn't mean to change the nodename, but rather aliases.
> BTW nodes should be sorted by nodename (placed at the top).
>
> > ... However, 5V_OUT
> > is a distinct net in the schematic. Keeping the node makes the DT
> > power tree accurately reflect the hardware and clearly documents
> > that both the USB VBUS and HDMI 5V domains share this OR-ed source.
>
> It is not an independent network. 5V_BOOST and 5V_OUT are on the same
> VOUT, only separated by a diode. The device tree describes the hardware.
> 5V_OUT is not a regulator, it has no enable control, so treating it as
> a standalone regulator is incorrect.
>
> > ... For now, chaining
> > `vcc5v0_usb30_otg0` -> `5v_out` -> `5v_boost` is the most accurate
> > representation.
>
> Adding a fake regulator is just a waste of startup time.
Hi,
Thanks for the feedback.
I understand your concern regarding 5V_OUT not being a standalone
physical regulator. However, I'd prefer to keep the node for two
reasons:
1. Consistency: The DTS already models other always-on fixed rails
without any enable control (e.g., vccin_5v, vcc_sysin, vcc_syson).
Keeping 5v_out is consistent with this established pattern in the
same file.
2. Accuracy to the schematic: 5V_OUT is a distinct net where the
external DC input and the boost output are OR-ed together. Keeping
this node makes the DT power tree a 1:1 mapping to the hardware
schematic, clearly documenting that both USB VBUS and HDMI 5V share
this OR-ed source.
Regarding the startup time, a fixed-regulator without GPIO or clock
controls does no hardware I/O during probe, so the overhead is
negligible.
On the node ordering: the node is named `regulator-5v-boost` (starting
with 'r'), so it is correctly sorted after `battery` and `chosen`.
Coia
More information about the Linux-rockchip
mailing list