[PATCH v2 1/1] spi: use dmaengine_desc_set_callback()

Krzysztof Kozlowski krzk at kernel.org
Mon Nov 9 14:10:38 PST 2026


On 09/11/2026 18:57, Andy Shevchenko wrote:
> On Fri, Nov 06, 2026 at 08:20:33AM +0100, Krzysztof Kozlowski wrote:
>>>>
>>>> Statement of oversight DOES NOT include "part of the patch".
>>>
>>> So, it means I MUST from now on REQUIRE a split before reviewing.
>>> Right?
>>
>> Why "from now on"? The reviewer's statement of oversight is worded like
>> that since beginning? Also nothing stops you from reviewing parts. We
>> discuss the statement of oversight and its result: giving Rb tag. The Rb
>> tag is not output of some review, but agreement with statement of
>> oversight and performing what is stated there.
>>
>> You can review parts, but you do not provide Rb tag.
> 
> No, I'm not going to review something that I may not put Rb tag on.
> I can NAK or ignore (or Ack without viewing, but it equals to ignore to me).


That's your call, but you put it on yourself, so do not blame us for "I
MUST from now on REQUIRE"...


Best regards,
Krzysztof



More information about the Linux-rockchip mailing list