[PATCH v15 02/15] accel/rocket: take the completion register writes under job_lock
Heiko Stübner
heiko at sntech.de
Tue Nov 3 14:45:30 PST 2026
Am Sonntag, 1. November 2026, 09:22:54 Mitteleuropäische Normalzeit schrieb Jiaxing Hu:
> rocket_job_handle_irq() writes OPERATION_ENABLE and INTERRUPT_CLEAR before
> taking job_lock, while rocket_job_hw_submit() writes OPERATION_ENABLE under
> it, so a completion can write its zero after a submit has written its one
> and stop a task that has just started. Move both writes inside the existing
> scoped_guard().
>
> Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")
> Signed-off-by: Jiaxing Hu <gahing at gahingwoo.com>
> Tested-by: Igor Paunovic <royalnet026 at gmail.com> # RK3588, three cores, induced reset, JOB_TIMEOUT_MS=2
Reviewed-by: Heiko Stuebner <heiko at sntech.de>
More information about the Linux-rockchip
mailing list