[PATCH v1 2/3] dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint
Damon Ding
damon.ding at rock-chips.com
Thu May 14 19:53:37 PDT 2026
Hi Conor,
On 5/15/2026 2:19 AM, Conor Dooley wrote:
> On Thu, May 14, 2026 at 03:01:32PM +0800, Damon Ding wrote:
>> Add data-lanes property support to the port at 1 endpoint for physical
>> lane mapping configuration.
>>
>> Signed-off-by: Damon Ding <damon.ding at rock-chips.com>
>> ---
>> .../bindings/display/bridge/analogix,dp.yaml | 24 +++++++++++++++----
>> 1 file changed, 20 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
>> index 62f0521b0924..a82f9b7776c0 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
>> @@ -36,19 +36,35 @@ properties:
>> Hotplug detect GPIO.
>> Indicates which GPIO should be used for hotplug detection
>>
>> + data-lanes:
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> + deprecated: true
>
> Why are you adding a new property as deprecated? Why does this duplicate
> what you're adding to the port node? At the very least, your commit is
> lacking an explanation.
> pw-bot: changes-requested
>
Thank you for the review.
I referenced the implementation in
Documentation/devicetree/bindings/display/msm/dp-controller.yaml. After
evaluating QCOM DP driver and other drivers, I agree that implementing
'data-lanes' in the endpoint node is the preferred and common approach
nowadays.
The top-level `data-lanes` property together with the `deprecated` mark
was leftover content from my early reference and arrangement, which I
neglected to delete before submitting. It is redundant, unreasonable and
should not have been added at all.
I will fix it in the next version.
Best regards,
Damon
>
>> + minItems: 1
>> + maxItems: 4
>> + items:
>> + maximum: 3
>> +
>> ports:
>> $ref: /schemas/graph.yaml#/properties/ports
>>
>> properties:
>> port at 0:
>> $ref: /schemas/graph.yaml#/properties/port
>> - description:
>> - Input node to receive pixel data.
>> + description: Input node to receive pixel data.
>>
>> port at 1:
>> $ref: /schemas/graph.yaml#/properties/port
>> - description:
>> - Port node with one endpoint connected to a dp-connector node.
>> + description: Port node with one endpoint connected to sink device node.
>> + properties:
>> + endpoint:
>> + $ref: /schemas/media/video-interfaces.yaml#
>> + unevaluatedProperties: false
>> + properties:
>> + data-lanes:
>> + minItems: 1
>> + maxItems: 4
>> + items:
>> + enum: [ 0, 1, 2, 3 ]
>>
>> required:
>> - port at 0
>> --
>> 2.34.1
>>
More information about the Linux-rockchip
mailing list