[BUG] rkvdec-vdpu383-h264: wrong pixels at horizontal de-blocking edges y=4 and y=12
Piotr Oniszczuk
piotr.oniszczuk at gmail.com
Thu Jun 11 00:40:40 PDT 2026
> Wiadomość napisana przez Simon Wright <simon at symple.nz> w dniu 11 cze 2026, o godz. 08:15:
>
> Hi Piotr,
>
> Short version: the in-tree port didn't actually have the warmup running (it needs a
> probe-time buffer alloc + a pm_runtime_resume hook, not just the decode code). Rather
> than pick that apart, here's a clean patch that wires it properly - and I've now
> validated it on hardware.
Happy to hear that.
(I was afraid your excellent work will not solve my issue…)
>
> The patch is self-contained and needs no devicetree change (mainline already maps the
> "link" register bank it uses); git apply-clean on 7.0 and 7.1-rc7:
>
>
> dmesg | grep -i "deblock-priming"
> # expect: "RK3576 H.264 deblock-priming workaround enabled"
>
Im seeing this so all good.
> I validated it on the two RK3576 boards here: on a NanoPi R76S the warmup takes BBB
> from ~18% of decodes corrupt to 0/40; on an ArmSoM Sige5 the unpatched HW decode is
> 100% corrupt, and the corruption looks exactly like the photo you shared. Before/after
> captures:
Pls give me few days - I ask test users to give daily usage test runs to make sure users will be happy
(So far my short lab tests showing all good)
Simon: fantastic work!
More information about the Linux-rockchip
mailing list