[PATCH V10 3/9] iio: imu: inv_icm42607: Add inv_icm42607 Core Driver

[Chris Morgan]

On Tue, Jun 09, 2026 at 09:57:55PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 08, 2026 at 03:52:38PM -0500, Chris Morgan wrote:
> > On Fri, Jun 05, 2026 at 07:08:35PM +0300, Andy Shevchenko wrote:
> > > On Thu, Jun 04, 2026 at 03:18:25PM -0500, Chris Morgan wrote:
> 
> ...
> 
> > > > +struct inv_icm42607_sensor_conf {
> > > > +	int mode;
> > > > +	int fs;
> > > > +	int odr;
> > > > +	int filter;
> > > 
> > > All of them are supposed to be signed? Why?
> 
> > > > +};
> > 
> > A later commit will use -1 for invalid values.
> 
> Okay, perhaps add a comment on top that negative values will mean invalid case?

Will do.

> 
> ...
> 
> > > > +#include <linux/delay.h>
> > > > +#include <linux/dev_printk.h>
> > > > +#include <linux/interrupt.h>
> > > > +#include <linux/iio/iio.h>
> > > > +#include <linux/module.h>
> > > > +#include <linux/mutex.h>
> > > > +#include <linux/property.h>
> > > > +#include <linux/regmap.h>
> > > > +#include <linux/regulator/consumer.h>
> > > 
> > > IWYU, please.
> > 
> > This may sound like a dumb question, but what's the best way to invoke
> > iwyu for a kernel? None of the readmes or man pages seem to be getting
> > me anywhere...
> 
> In this list we (I mean community related to IIO) discussed iwyu tool and
> its best configuration. Yep, it's barely good and far from ideal, but that's
> what we have currently. Otherwise `git grep ...` and cscope are your friends
> to answer this. Also doing review on regular basis makes this knowledge
> developed better.
> 

Since git grep (and elixir.bootlin.com) are the tools I know best, I'll
try to sensibly pare down the includes where I can. I do see that the
interrupt include isn't needed anymore so I can drop that one. If
anything else jumps out let me know and I'll exclude it too. There's a
few other things I'm going to pare out since sashiko.dev bot correctly
pointed out some of my code is now dead since I removed buffers support
(because I don't have an interrupt on this device).

> ...
> 
> > It will get extended, so I'll keep this for now if that's okay.
> 
> It's okay.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Thank you,
Chris