[PATCH v2 04/12] arm64: dts: rockchip: rk3588s-nanopi: add missing sdmmc cd pinctrl
Jonas Karlman
jonas at kwiboo.xyz
Fri Jul 10 16:18:27 PDT 2026
Hi Joachim,
On 7/11/2026 12:11 AM, Joachim Eastwood via B4 Relay wrote:
> From: Joachim Eastwood <joachim.eastwood at gmail.com>
>
> The cd (card detect) pin is used, but not reserved through pinctrl.
Maybe this and some/most of the other DT changes that fixes some missing
bits should put first in this series and with Fixes tags?
Regards,
Jonas
>
> Signed-off-by: Joachim Eastwood <joachim.eastwood at gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi
> index d41c49716fa2..a8f32b994b10 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi
> @@ -336,6 +336,10 @@ rtc_int: rtc-int {
> };
>
> sdmmc {
> + sdmmc_det_pin: sdmmc-det-pin {
> + rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> +
> sd_s0_pwr: sd-s0-pwr {
> rockchip,pins = <4 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>;
> };
> @@ -407,6 +411,8 @@ &sdmmc {
> no-mmc;
> no-sdio;
> sd-uhs-sdr104;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_det_pin>;
> vmmc-supply = <&vcc_3v3_sd_s0>;
> vqmmc-supply = <&vccio_sd_s0>;
> status = "okay";
>
More information about the Linux-rockchip
mailing list