[PATCH 1/7] media: verisilicon: Fix the cleanup when a codec ->run() fails

Nicolas Dufresne nicolas.dufresne at collabora.com
Wed Aug 19 08:05:35 PDT 2026


Hi Sascha,

Le mercredi 19 août 2026 à 12:37 +0200, Sascha Hauer a écrit :
>  	ret = start_prepare_run(ctx, &decode_params);
>  	if (ret) {
> -		hantro_end_prepare_run(ctx);
> +		hantro_end_prepare_run(ctx, ret);

Since its already in an if (ret) branch, and for code readability, can you use
hantro_abort_prepare_run(ctx) instead and leave all other sucessful calls as-is.

Nicolas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20260819/5faa17ab/attachment.sig>


More information about the Linux-rockchip mailing list