[PATCH 5/7] arm64: dts: mediatek: Add #{address,size}-cells to Chromium-based /firmware
Doug Anderson
dianders at chromium.org
Thu Apr 30 16:54:42 PDT 2026
Hi,
On Tue, Apr 28, 2026 at 1:07 PM Brian Norris <briannorris at chromium.org> wrote:
>
> Chromium/Depthcharge bootloaders may dynamically add a few device nodes
> to a system's DTB under a /firmware node. A typical DT looks something
> like the following:
>
> / {
> firmware {
> ranges;
>
> coreboot {
> compatible = "coreboot";
> reg = <...>;
> ...;
> };
> };
> };
>
> Notably, the /firmware node has an empty 'ranges', but does not have
> address/size-cells.
>
> Commit 6e5773d52f4a ("of/address: Fix WARN when attempting translating
> non-translatable addresses") started requiring #address-cells for a
> device's parent if we want to use the reg resource in a device node.
> This leads to errors like the following:
>
> [ 7.763870] coreboot_table firmware:coreboot: probe with driver coreboot_table failed with error -22
>
> Add appropriate #{address,size}-cells to work around the problem.
>
> Note that Google has also patched the Depthcharge bootloader source to
> add {address,size}-cells [1], but bootloader updates are typically
> delivered only via Google OS updates. Not all users install Google
> software updates, and even if they do, Google may not produce updated
> binaries for all/older devices.
>
> [1] https://lore.kernel.org/all/20241209092809.GA3246424@google.com/
> https://crrev.com/c/6051580 ("coreboot: Insert #address-cells and
> #size-cells for firmware node")
>
> Closes: https://lore.kernel.org/all/aeKlYzTiL0OB1y3g@google.com/
> Fixes: 6e5773d52f4a ("of/address: Fix WARN when attempting translating non-translatable addresses")
> Signed-off-by: Brian Norris <briannorris at chromium.org>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 +++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 5 +++++
> arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 5 +++++
> arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi | 5 +++++
> arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 5 +++++
> arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 5 +++++
> 6 files changed, 30 insertions(+)
Reviewed-by: Douglas Anderson <dianders at chromium.org>
More information about the Linux-rockchip
mailing list