[v2,PATCH 2/5] RK3566 BTT Pi2 - Fix GMAC default delays.

Jonas Karlman jonas at kwiboo.se
Fri Sep 12 08:06:08 PDT 2025


Hi Andrey,

On 9/10/2025 11:54 PM, Andrey Leonchikov wrote:
> Simple patch to avoid a warning on GMAC driver initialization.
> Default values same to a manufacturer DTS.
> Signed-off-by: Andrey Leonchikov <andreil499 at gmail.com>
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> index fdf7d00edf4d..d31b9bd54162 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> @@ -265,6 +265,8 @@ &gmac1m0_rx_bus2
>  			&gmac1m0_rgmii_clk
>  			&gmac1m0_clkinout
>  			&gmac1m0_rgmii_bus>;
> +	tx_delay = <0x19>;
> +	rx_delay = <0x05>;

This is using phy-mode = rgmii-id, so tx/rx_delay should not be needed.

Please do not add these just to avoid a warning by the driver, the
driver should more likely be fixed not to warn about missing props.

Currently the driver wont apply these delays due to use of rgmii-id,
however in future the driver may be changed to be able to use these
props to apply a small delay on top of the PHY applied delay. I have
patches for these in my local tree that is on my todo to send out.

Please drop this patch to avoid new issues in the future.

Regards,
Jonas

>  	status = "okay";
>  };
>  




More information about the Linux-rockchip mailing list