[PATCH] PCI: rockchip: Propagate dev_err_probe return value
Markus Elfring
Markus.Elfring at web.de
Sat Oct 18 00:15:29 PDT 2025
…
> +++ b/drivers/pci/controller/pcie-rockchip.c
> @@ -134,7 +134,7 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip)
> err = reset_control_bulk_assert(ROCKCHIP_NUM_CORE_RSTS,
> rockchip->core_rsts);
> if (err) {
> - dev_err_probe(dev, err, "Couldn't assert Core resets\n");
> + err = dev_err_probe(dev, err, "Couldn't assert Core resets\n");
> goto err_exit_phy;
> }
I find such a variable reassignment not helpful here.
Do you really miss an error code propagation?
Regards,
Markus
More information about the Linux-rockchip
mailing list