[PATCH v11 00/17] media: rockchip: add a driver for the rockchip camera interface

[Michael Riesch]

Hi Bryan,

On 10/10/25 14:15, Bryan O'Donoghue wrote:
> On 17/09/2025 16:38, Michael Riesch via B4 Relay wrote:
>> Habidere,
>>
>> This series introduces support for the Rockchip Camera Interface (CIF),
>> which is featured in many Rockchip SoCs in different variations.
>> For example, the PX30 Video Input Processor (VIP) is able to receive
>> video data via the Digital Video Port (DVP, a parallel data interface)
>> and transfer it into system memory using a double-buffering mechanism
>> called ping-pong mode.
>> The RK3568 Video Capture (VICAP) unit, on the other hand, features a
>> DVP and a MIPI CSI-2 receiver that can receive video data independently
>> (both using the ping-pong scheme).
>> The different variants may have additional features, such as scaling
>> and/or cropping.
>> Finally, the RK3588 VICAP unit constitutes an essential piece of the
>> camera interface with one DVP, six MIPI CSI-2 receivers, scale/crop
>> units, and a data path multiplexer (to scaler units, to ISP, ...).
>>
>> The v11 of the series adds a media controller centric V4L2 device driver
>> for the Rockchip CIF with
>>   - support for the PX30 VIP (not tested, though, due to the lack of HW)
>>   - support for the RK3568 VICAP, including
>>      - capturing frames from the DVP
>>      - capturing frames from the MIPI CSI-2 receiver
>>   - abstraction for the ping-pong scheme to allow for future extensions
>>   - abstraction for the INTERFACE and CROP parts to allow for future
>>     extensions
>>   - initial support for different virtual channels (not tested, though,
>>     due to the lack of HW)
>> and a V4L2 subdevice driver for the Rockchip MIPI CSI-2 Receiver.
>>
>> The driver can be readily extended to provide support for the RK3588
>> VICAP variant. In order to keep things simple, however, this extension
>> shall be submitted separately.
>>
>> Looking forward to your comments!
>>
>> To: Mehdi Djait<mehdi.djait at linux.intel.com>
>> To: Maxime Chevallier<maxime.chevallier at bootlin.com>
>> To: Théo Lebrun<theo.lebrun at bootlin.com>
>> To: Thomas Petazzoni<thomas.petazzoni at bootlin.com>
>> To: Gerald Loacker<gerald.loacker at wolfvision.net>
>> To: Bryan O'Donoghue<bryan.odonoghue at linaro.org>
>> To: Markus Elfring<Markus.Elfring at web.de>
>> To: Sakari Ailus<sakari.ailus at iki.fi>
>> To: Laurent Pinchart<laurent.pinchart at ideasonboard.com>
>> To: Mauro Carvalho Chehab<mchehab at kernel.org>
>> To: Rob Herring<robh+dt at kernel.org>
>> To: Krzysztof Kozlowski<krzk+dt at kernel.org>
>> To: Conor Dooley<conor+dt at kernel.org>
>> To: Heiko Stuebner<heiko at sntech.de>
>> To: Kever Yang<kever.yang at rock-chips.com>
>> To: Nicolas Dufresne<nicolas.dufresne at collabora.com>
>> To: Sebastian Reichel<sebastian.reichel at collabora.com>
>> To: Collabora Kernel Team<kernel at collabora.com>
>> To: Paul Kocialkowski<paulk at sys-base.io>
>> To: Alexander Shiyan<eagle.alexander923 at gmail.com>
>> To: Val Packett<val at packett.cool>
>> To: Rob Herring<robh at kernel.org>
>> To: Philipp Zabel<p.zabel at pengutronix.de>
>> Cc:linux-media at vger.kernel.org
>> Cc:devicetree at vger.kernel.org
>> Cc:linux-kernel at vger.kernel.org
>> Cc:linux-arm-kernel at lists.infradead.org
>> Cc:linux-rockchip at lists.infradead.org
>> Signed-off-by: Michael Riesch<michael.riesch at wolfvision.net>
>> Signed-off-by: Michael Riesch<michael.riesch at collabora.com>
>>
>> Changes in v11:
>> - rkcif: split large driver patch (6/13 of v10) into smaller
>>    patches (6-11/17 of v11) (Bryan)
>> - rkcsi: replaced devm_reset_control_array_get_exclusive with
>>    devm_reset_control_get_exclusive (Philipp)
>> - Link to v10:https://lore.kernel.org/r/20240220-rk3568-vicap-
>> v10-0-62d8a7b209b4 at collabora.com
> 
> I believe it is the case and please feel free to correct me if I'm wrong
> that you've dropped a long list of sob/co-develop-by, I think we
> discussed that too, because of the level of change, it seems reasonable
> too.

Correct. The tag list used to be quite complicated [0] due to the
complicated history of this driver. Maxime worked on the driver up to
v5, Mehdi up to v14, I added RK3568 support on top of Mehdi's v14 (with
some valuable contributions from Gerald) and submitted that as v1. v2 of
my work incorporated Mehdi's v14, and here we are, after several rounds
of feedback, at soon-to-be v12 (or, in fact, v25).

> On question on that, are these people aware of the change and cc'd on
> the list of recipients/contactable/agreeable to the change ?

I announced this plan as a response to your comment to v10 [1] with
Maxime, Mehdi and Gerald on Cc: and did not hear any objections.

Hope that this is still OK for everybody!

Best regards,
Michael

[0]
https://lore.kernel.org/linux-media/20240220-rk3568-vicap-v10-6-62d8a7b209b4@collabora.com/
[1]
https://lore.kernel.org/linux-media/23ccc744-745d-4a31-a79c-2d64bf1ed43d@collabora.com/