[PATCH 13/16] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3

[Nicolas Dufresne]

Hi,

Le mardi 07 octobre 2025 à 17:38 +0900, Krzysztof Kozlowski a écrit :
> On 07/10/2025 17:32, Sven Püschel wrote:
> > Add a new compatible for the rk3588 Rockchip SoC, which features an
> > RGA3, which is described in the TRM Part2.

Please write something here. You can't explain why RK did this, but at least
explain what are the differences and additional feature. It should also be super
clear through your patchset everything you didn't support, since when reading
your set, it really have nothing extra implemented.

> > 
> > Signed-off-by: Sven Püschel <s.pueschel at pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/media/rockchip-rga.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > index
> > ac17cda65191be047fc61d0c806f806c6af07c7b..11e86333c56aab55d9358dc88e45e7c1eb
> > faae9e 100644
> > --- a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > +++ b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > @@ -20,6 +20,7 @@ properties:
> >      oneOf:
> >        - const: rockchip,rk3288-rga
> >        - const: rockchip,rk3399-rga
> > +      - const: rockchip,rk3588-rga3
> 
> There is already rk3588-rga, so please explain in commit msg
> differences, including compatibility or lack thereof. I am confused why
> there are two completely different 2D accelerators simultaneously on
> that SoC.

It is quite strange hardware design, but this is really how the hardware is. I
personally don't expect an explanation from a third party. Its a mirror of the
VOP2 planes really.

Nicolas

> 
> Best regards,
> Krzysztof
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20251007/4f8b7587/attachment-0001.sig>