[PATCH 1/4] PCI: dwc: Advertise L1 PM Substates only if driver requests it

Bjorn Helgaas helgaas at kernel.org
Tue Nov 18 12:36:38 PST 2025


On Wed, Nov 12, 2025 at 09:22:36AM +0100, Niklas Cassel wrote:
> On Tue, Nov 11, 2025 at 04:16:08PM -0600, Bjorn Helgaas wrote:
> > --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> > @@ -1060,6 +1060,8 @@ int dw_pcie_setup_rc(struct dw_pcie_rp *pp)
> >  		PCI_COMMAND_MASTER | PCI_COMMAND_SERR;
> >  	dw_pcie_writel_dbi(pci, PCI_COMMAND, val);
> >  
> > +	dw_pcie_config_l1ss(pci);
> 
> The name dw_pcie_config_l1ss() sounds like we are enabling l1ss.
> 
> I know naming is hard.
> 
> Perhaps dw_pcie_disable_unsupported_l1ss() ?
> 
> Or something similar.

"disable" sounds like something we do with a control register, and
here we want to remove the advertised support from the capabilities
register.

Maybe dw_pcie_hide_unsupported_l1ss()?

Bjorn



More information about the Linux-rockchip mailing list