Re: [PATCH v2 2/2] arm64:?==?utf-8?q? dts: rockchip: Add Asus Tinker Board 3 and 3S device tree

[Dragan Simic]

Hello Michael,

Thanks for the v2!  Please, see one nitpick below.

On Friday, November 14, 2025 16:46 CET, michael.opdenacker at rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker at rootcommit.com>

I'm sorry for not mentioning it in my earlier responses, but this
line is redundant, because it duplicates the From value found in
the actual email message.

> Add initial device tree support for Asus Tinker Board 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
> 
> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> and a "mask ROM" DIP switch (to mask the eMMC and enter "Mask ROM"
> mode for recovery) to the "3" version.
> 
> This adds support for:
> - Debug UART (/dev/ttyS2)
> - SD card (/dev/mmcblk1)
> - eMMC (/dev/mmcblk0, only on Tinker Board 3S)
> - I2C:
>   - i2c0 (internal bus with a PMIC and regulators)
>   - i2c2 (internal bus with an at24 eeprom and an RTC device)
> - USB 2.0 ports
> - 2 GPIO LEDS
> 
> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker at rootcommit.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   2 +
>  .../dts/rockchip/rk3566-tinker-board-3.dts    |  14 +
>  .../dts/rockchip/rk3566-tinker-board-3.dtsi   | 280 ++++++++++++++++++
>  .../dts/rockchip/rk3566-tinker-board-3s.dts   |  30 ++
>  4 files changed, 326 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dts
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtsi
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dts

[snip]