Re: [PATCH v6 0/3] Add Radxa CM5 and IO Board

Dragan Simic dsimic at manjaro.org
Fri Nov 14 00:10:13 PST 2025


On Friday, November 14, 2025 08:28 CET, Krzysztof Kozlowski <krzk at kernel.org> wrote:
> On 14/11/2025 08:26, Dragan Simic wrote:
> > On Friday, November 14, 2025 08:22 CET, Krzysztof Kozlowski <krzk at kernel.org> wrote:
> >> On 14/11/2025 08:17, Dragan Simic wrote:
> >>> On Friday, November 14, 2025 08:10 CET, Krzysztof Kozlowski <krzk at kernel.org> wrote:
> >>>> On 14/11/2025 06:03, FUKAUMI Naoki wrote:
> >>>>> On 11/12/25 09:46, Dragan Simic wrote:
> >>>>>> On Wednesday, November 12, 2025 00:26 CET, FUKAUMI Naoki <naoki at radxa.com> wrote:
> >>>>>>> On 11/11/25 23:33, Dragan Simic wrote:
> >>>>>>>> On Tuesday, November 11, 2025 12:52 CET, FUKAUMI Naoki <naoki at radxa.com> wrote:
> >>>>>>>>> On 11/6/25 02:48, Joseph Kogut wrote:
> >>>>>>>>>> On Wed, Nov 5, 2025 at 4:15 AM FUKAUMI Naoki <naoki at radxa.com> wrote:
> >>>>>>>>>>> I'd like to clarify the situation regarding the v6 patch series I submitted.
> >>>>>>>>>>>
> >>>>>>>>>>> The original device tree work for the Radxa CM5 and IO Board was
> >>>>>>>>>>> authored by Joseph Kogut. I took over the responsibility of getting it
> >>>>>>>>>>> upstreamed with his agreement.
> >>>>>>>>>>
> >>>>>>>>>> I'll confirm this. I've been in communication with Naoki. They made a
> >>>>>>>>>> large number of revisions to my original patch series, which I think
> >>>>>>>>>> have technical merit. I suggested they submit the patches themselves,
> >>>>>>>>>> and gave them explicit permission to add my Signed-off-by and CC me.
> >>>>>>>>>>
> >>>>>>>>>> I assume this was the correct way for them to continue the work I
> >>>>>>>>>> started, but if not, please let us know the best way to proceed.
> >>>>>>>>>
> >>>>>>>>> Can anyone help us?
> >>>>>>>>
> >>>>>>>> I'm not exactly sure how to resolve the current situation, but for
> >>>>>>>> Signed-off-by tags to be present, in this case you'd need to have
> >>>>>>>> Co-developed-by tags as well, because the final patch versions,
> >>>>>>>> which would be submitted by Naoki, would differ significantly from
> >>>>>>>> the versions that Joseph actively worked on, if I understood
> >>>>>>>> everything correctly.  Though, for Joseph's Signed-off-by tags to
> >>>>>>>> be included there, he would also need to participate actively in
> >>>>>>>> the development of the final patch versions.
> >>>>>>>
> >>>>>>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
> >>>>>>>
> >>>>>>> If
> >>>>>>> ----
> >>>>>>> From: Joseph Kogut <joseph.kogut at gmail.com>
> >>>>>>>
> >>>>>>> <changelog>
> >>>>>>>
> >>>>>>> Signed-off-by: Joseph Kogut <joseph.kogut at gmail.com>
> >>>>>>> Co-developed-by: FUKAUMI Naoki <naoki at radxa.com>
> >>>>>>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> >>>>>>> ----
> >>>>>>> then I can submit my patch series?
> >>>>>>
> >>>>>> Actually, the Co-developed-by tags would be pointing to Joseph
> >>>>>> in that case, but as I described it above, this approach basically
> >>>>>> cannot be used, because Joseph's original work differs a lot from
> >>>>>> what you'd actually submit to the mailing list(s).
> >>>>>>
> >>>>>>> Or,
> >>>>>>>
> >>>>>>>> Another option, technically a bit simpler, would be to include just
> >>>>>>>> Originally-by tags for Joseph, which would indicate that Joseph gave
> >>>>>>>> up on the development of the patches and handed them over to Naoki
> >>>>>>>> for future development and submission to the mailing lists. Though,
> >>>>>>>> that would require Joseph to publicly state exactly that.
> >>>>>>>
> >>>>>>> I cannot find any documentation about "Originally-by".
> >>>>>>> Is this correct?
> >>>>>>> ----
> >>>>>>> <changelog>
> >>>>>>>
> >>>>>>> Originally-by: Joseph Kogut <joseph.kogut at gmail.com>
> >>>>
> >>>> There is no such tag. Don't invent tags.
> >>>
> >>> True, it doesn't exist officially, but it's been used fairly often.
> >>>
> >>>>>>> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> >>>>>>> ----
> >>>>>>
> >>>>>> That approach is the only I see applicable in this case.  However,
> >>>>>> let's hear opinions from other people as well.
> >>>>>
> >>>>> I see. I want to do this approach.
> >>>>>
> >>>>> Joseph, could you give me a statement to do this?
> >>>>
> >>>> Use standard authorship and standard tags, some of which are explained
> >>>> in Submitting patches.
> >>>
> >>> Frankly, your suggestion is useless, because it doesn't explain what 
> >>> to do in this particular case.
> >>
> >> Maybe because you did not read the doc...
> > 
> > I think you already know the answer: I read it multiple times and 
> > used it as a reference more than once.
> 
> Then if you read it and saw my objection to inventing tags, you could
> guess that only first solution for patches with changes coming from
> multiple authors is allowed. Also you would find from that doc, that
> patches which were not changed - like in this patchset - must be
> attributed to single author followed by SoB. So both cases nicely
> explained. Pretty simple once you remove the invented tag option,
> because it is really unnecessary.

Thanks, I appreciate your detailed response.

Let's have a look at the following excerpt from Documentation/
process/submitting-patches.rst:

 503 Co-developed-by: states that the patch was co-created by multiple developers;
 504 it is used to give attribution to co-authors (in addition to the author
 505 attributed by the From: tag) when several people work on a single patch.  Since
 506 Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
 507 followed by a Signed-off-by: of the associated co-author.  Standard sign-off
 508 procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
 509 chronological history of the patch insofar as possible, regardless of whether
 510 the author is attributed via From: or Co-developed-by:.  Notably, the last
 511 Signed-off-by: must always be that of the developer submitting the patch.

Following that, you're absolutely right that the above-described
first approach is the way to go.  However, providing a Signed-off-by
actually means that, at least formally, the signer becomes legally
responsible for the code in the patch;  I'm not sure how fair is it
for someone to become responsible for something that happened long
time ago, about which they have no longer a clue about, which may
happen in case someone rescues an old, abandoned patch, and changes
or improves it a lot before submitting it to a mailing list?

Of course, what I described is more of a hypothetical case, but the
documentation should be covering such cases as well.

That's where Originally-by, I think, comes as a possible solution;
it's a bit like Acked-by, i.e. it's a "lighter" version of Signed-
off-by, in the sense of effectively not making someone legally
responsible for the code they originally authored but have had
abandoned and which someone else is now submitting, while still
providing the mandatory attribution.

I hope it makes sense.




More information about the Linux-rockchip mailing list