Re: [PATCH v3 1/3] arm64:?==?utf-8?q? dts: rockchip: Use default-state for power LED for Radxa boards

[Dragan Simic]

Hello Naoki,

On Thursday, November 13, 2025 13:42 CET, FUKAUMI Naoki <naoki at radxa.com> wrote:
> Currently, on Radxa boards, the power LED is turned on immediately
> after power-up, independent of software control. The heartbeat LED and
> other available LEDs are subsequently turned on by the initial
> software, such as U-Boot, to indicate software is running.
> 
> However, the device tree description for this behavior is inconsistent
> and fragmented, with definitions split between the main Linux DTS
> files and separate U-Boot files (u-boot/arch/arm/dts/*-u-boot.dtsi).
> 
> This patch addresses the inconsistency for the power LED by using
> default-state = "on" instead of linux,default-trigger = "default-on".
> 
> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts    | 1 -
>  arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts      | 1 -
>  arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts      | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts   | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts     | 2 +-
>  6 files changed, 4 insertions(+), 6 deletions(-)

[snip]

Thanks for this patch.  The introduces changes look consistent
to me, so please feel free to include

Reviewed-by: Dragan Simic <dsimic at manjaro.org>