Re: [PATCH 2/4] arm64:?==?utf-8?q? dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A

[Dragan Simic]

Hello Naoki,

Thanks for this patch.  Please, see one remark below.

On Tuesday, November 11, 2025 06:09 CET, FUKAUMI Naoki <naoki at radxa.com> wrote:
> The VCC supply for the BL24C16 EEPROM chip found on Radxa ROCK 5A is
> vcc_3v3_pmu, which is routed to vcc_3v3_s3 via a zero-ohm resistor.
> Describe this supply.
> 
> Fixes: 89c880808cff8 ("arm64: dts: rockchip: add I2C EEPROM to rock-5a")
> Link: https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf p.19

The same suggestion about using explicitly placed references, from
the patch 1/4 in this series, applies here as well.

> Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> index 428c6f0232a34..041a0fff22ccb 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> @@ -233,6 +233,7 @@ eeprom: eeprom at 50 {
>  		compatible = "belling,bl24c16a", "atmel,24c16";
>  		reg = <0x50>;
>  		pagesize = <16>;
> +		vcc-supply = <&vcc_3v3_pmu>;
>  	};
>  };
>  
> @@ -600,7 +601,7 @@ regulator-state-mem {
>  				};
>  			};
>  
> -			vcc_3v3_s3: dcdc-reg8 {
> +			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
>  				regulator-name = "vcc_3v3_s3";
>  				regulator-always-on;
>  				regulator-boot-on;