[PATCH 2/2] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 5A
FUKAUMI Naoki
naoki at radxa.com
Mon Nov 10 06:47:05 PST 2025
Hi Dragan,
On 11/10/25 23:37, Dragan Simic wrote:
> On Monday, November 10, 2025 10:44 CET, FUKAUMI Naoki <naoki at radxa.com> wrote:
>> On 11/10/25 16:38, Dragan Simic wrote:
>> (snip)>>> Additionally, it would make sense to squash this patch and your
>>>>> other patch that addresses the ROCK 5C together. They're very
>>>>> similar and having them together in a single commit might actually
>>>>> help the people browsing the repository understand it better.
>>>>
>>>> I'll drop eeprom patch from ROCK 5C v7 patch series, and squash eeprom
>>>> patches for ROCK 3C/5A/5C.
>>>
>>> Thanks!
>>
>> I'm preparing a patch series for Radxa ROCK 5A and I just remembered
>> that the eeprom node in 5a.dts is totally incorrect. The eeprom is on
>> i2c0, not on i2c2.
>>
>> I'm planning to include this eeprom fix as a part of the patch series
>> for 5A.
>
> You're right, and I managed to miss that during my review. :/
>
> It would be good if you'd prepare and send a separate, two-patch
> series with just the I2C bus fix for the ROCK 5A and the squashed
> patch that makes the EEPROMs read-only on three boards. Reviewing
> and accepting large changes split into smaller portions is always
> easier.
I see. I'll do it first.
Thank you very much for your advice!
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
More information about the Linux-rockchip
mailing list