[RFC PATCH] arm64: dts: rockchip: Fix microSD card detect for Radxa ROCK 5 ITX
Heiko Stübner
heiko at sntech.de
Mon Nov 10 02:05:18 PST 2025
Hi,
Am Montag, 10. November 2025, 04:16:37 Mitteleuropäische Normalzeit schrieb FUKAUMI Naoki:
> On 11/10/25 12:00, FUKAUMI Naoki wrote:
> > Due to the discussion about cd-gpios and sdmmmc_det pin
> > functionality[1], it would be better to use cd-gpios for now.
> >
> > [1] https://lore.kernel.org/linux-rockchip/20240912152538.1.I858c2a0bf83606c8b59ba1ab6944978a398d2ac5@changeid/T/#u
> >
> > Fixes: 31390eb8ffbf2 ("arm64: dts: rockchip: add ROCK 5 ITX board")
> > Signed-off-by: FUKAUMI Naoki <naoki at radxa.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> > index bc8140883de47..391c6482e8ee3 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> > @@ -670,6 +670,12 @@ led_pins: led-pins {
> > };
> > };
> >
> > + mmc {
> > + sdmmc_det_gpio: sdmmc-det-gpio {
> > + rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>;
> > + };
> > + };
> > +
>
> I got following error:
>
> $ make CHECK_DTBS=y rockchip/rk3588-rock-5-itx.dtb
> UPD include/config/kernel.release
> DTC [C] arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dtb
> /home/radxa/linux/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dtb:
> mmc: sdmmc-det-gpio: {'rockchip,pins': [[0, 4, 0, 270]], 'phandle': 145}
> is not of type 'array'
> from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
>
> What's wrong?
the problem is the "-gpio" in the pinctrl node-name,which triggers
a pattern matching against a normal gpios property.
So ideally rename sdmmc-det-gpio to sdmmc-det-pin or so.
Hope that helps
Heiko
More information about the Linux-rockchip
mailing list