[PATCH 2/5] arm64: dts: rockchip: Add Additional pinctrl defs for Indiedroid Nova

[Chris Morgan]

On Thu, Nov 06, 2025 at 08:45:33PM +0100, Heiko Stuebner wrote:
> Hi Chris,
> 
> Am Mittwoch, 5. November 2025, 21:57:05 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> > From: Chris Morgan <macromorgan at hotmail.com>
> > 
> > Define the pinctrl nodes for the WiFi interrupts, correct the pinctrl
> > for the ethernet according to the schematic, and add the clk32k_in
> > control for the RTC. Add the correct regulator mapping for the PCIE
> > too.
> 
> way too much completely different things to stuff into one patch.

Sorry, to me this seemed like a few tiny fixes that, excluding the pcie
regulator addition, all related to correcting pinctrl definitions. I'll
be happy to split it up if need be. The SDIO wifi is really just adding
the interrupt pin... there was just a bit of stuff to add on top so I
could define it correctly; for ethernet I'm replacing the reset pin with
the PCIE port reset pin and adding other PCIE pins defined in the
schematic, and the clk32k_in is just adding another pin to note that the
RTC output is connected to that pin.

Thank you,
Chris

> 
> - Adding the sdio wifi is one
> - ethernet is next ... you're not fixing, but removing the pinctrl?
> - pcie2 fixes is another one
> - and the clkin32k as well
> 
> 
> Heiko
> 
> > 
> > Signed-off-by: Chris Morgan <macromorgan at hotmail.com>
> > ---
> >  .../dts/rockchip/rk3588s-indiedroid-nova.dts  | 43 ++++++++++++-------
> >  1 file changed, 28 insertions(+), 15 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
> > index debab7732b71..f40782b6c7db 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
> > @@ -406,7 +406,7 @@ rtc_hym8563: rtc at 51 {
> >  		clock-output-names = "hym8563";
> >  		interrupt-parent = <&gpio0>;
> >  		interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
> > -		pinctrl-0 = <&hym8563_int>;
> > +		pinctrl-0 = <&hym8563_int>, <&clk32k_in>;
> >  		pinctrl-names = "default";
> >  		wakeup-source;
> >  	};
> > @@ -459,8 +459,11 @@ &i2s5_8ch {
> >  };
> >  
> >  &pcie2x1l2 {
> > -	pinctrl-0 = <&rtl8111_perstb>;
> > +	pinctrl-0 = <&pcie20x1m0_perstn>, <&pcie20x1m0_clkreqn>,
> > +		    <&pcie20x1m0_waken>;
> >  	pinctrl-names = "default";
> > +	reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
> > +	vpcie3v3-supply = <&vcc_3v3_s3>;
> >  	status = "okay";
> >  };
> >  
> > @@ -486,12 +489,6 @@ bt_wake_host: bt-wake-host {
> >  		};
> >  	};
> >  
> > -	ethernet-pins {
> > -		rtl8111_perstb: rtl8111-perstb {
> > -			rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_up>;
> > -		};
> > -	};
> > -
> >  	hym8563 {
> >  
> >  		hym8563_int: hym8563-int {
> > @@ -500,13 +497,6 @@ hym8563_int: hym8563-int {
> >  		};
> >  	};
> >  
> > -	sdio-pwrseq {
> > -		wifi_enable_h: wifi-enable-h {
> > -			rockchip,pins =
> > -				<0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> > -		};
> > -	};
> > -
> >  	usb-typec {
> >  		usbc0_int: usbc0-int {
> >  			rockchip,pins =
> > @@ -518,6 +508,18 @@ typec5v_pwren: typec5v-pwren {
> >  				<4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
> >  		};
> >  	};
> > +
> > +	wifi {
> > +		wifi_enable_h: wifi-enable-h {
> > +			rockchip,pins =
> > +				<0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> > +		};
> > +
> > +		wifi_host_wake_irq: wifi-host-wake-irq {
> > +			rockchip,pins =
> > +				<0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_down>;
> > +		};
> > +	};
> >  };
> >  
> >  &saradc {
> > @@ -538,6 +540,7 @@ &sdhci {
> >  };
> >  
> >  &sdio {
> > +	#address-cells = <1>;
> >  	bus-width = <4>;
> >  	cap-sd-highspeed;
> >  	cap-sdio-irq;
> > @@ -549,9 +552,19 @@ &sdio {
> >  	no-sd;
> >  	non-removable;
> >  	sd-uhs-sdr104;
> > +	#size-cells = <0>;
> >  	vmmc-supply = <&vcc_3v3_s3>;
> >  	vqmmc-supply = <&vcc_1v8_s3>;
> >  	status = "okay";
> > +
> > +	sdio_wifi: wifi at 1 {
> > +		reg = <1>;
> > +		interrupt-parent = <&gpio0>;
> > +		interrupts = <RK_PA0 IRQ_TYPE_LEVEL_LOW>;
> > +		interrupt-names = "host-wake";
> > +		pinctrl-0 = <&wifi_host_wake_irq>;
> > +		pinctrl-names = "default";
> > +	};
> >  };
> >  
> >  &sdmmc {
> > 
> 
> 
> 
>