[PATCH] media: rkvdec: Fix a NULL vs IS_ERR() bug in probe()
Dan Carpenter
dan.carpenter at linaro.org
Tue Jul 15 13:30:38 PDT 2025
On Wed, Jun 25, 2025 at 12:13:20PM -0400, Nicolas Dufresne wrote:
> Hi,
>
> Le mercredi 25 juin 2025 à 10:23 -0500, Dan Carpenter a écrit :
> > The iommu_paging_domain_alloc() function doesn't return NULL on error it
> > returns error pointers. Update the check and then set ->empty_domain to
> > NULL because the rest of the driver assumes it can be NULL.
> >
> > Fixes: ff8c5622f9f7 ("media: rkvdec: Restore iommu addresses on errors")
>
> Oh, sorry about that, I'll will test your patch this week, but otherwise
> looks good to me, fixing yet one more error path. I'll take the time
> to test dropping the iommu node from the DT while at it, as I simply
> don't remember if that was re-tested after that change.
>
> regards,
> Nicolas
>
Ping?
regards,
dan carpenter
More information about the Linux-rockchip
mailing list