[PATCH 1/2] Re: [PATCH 1/1] phy: rockchip: naneng-combphy: compatible with old DT for RK3568

[Chukun Pan]

Hi,
>> diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
>> index a1532ef8bbe9..372f5c07b5bd 100644
>> --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
>> +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
>> @@ -325,6 +325,10 @@ static int rockchip_combphy_parse_dt(struct device *dev, struct rockchip_combphy
>>  	priv->ext_refclk = device_property_present(dev, "rockchip,ext-refclk");
>>  
>>  	priv->phy_rst = devm_reset_control_get(dev, "phy");
>
> This should be devm_reset_control_get_exclusive().

I will change this.

>> +	/* fallback to old behaviour */
>> +	if (IS_ERR(ERR_PTR(priv->phy_rst)))
>
> Drop superfluous ERR_PTR().

I think it would be better if I changed it to this?

if (PTR_ERR(priv->phy_rst) == -ENOENT)
	priv->phy_rst = devm_reset_control_array_get_exclusive(dev);

Thanks,
Chukun

-- 
2.25.1