[PATCH v6 0/6] Add Synopsys DesignWare HDMI RX Controller

[Dmitry Osipenko]

On 2/17/25 11:34, Hans Verkuil wrote:
> Hi Dmitry,
> 
> On 15/02/2025 22:04, Dmitry Osipenko wrote:
>> This series implements support for the Synopsys DesignWare
>> HDMI RX Controller, being compliant with standard HDMI 1.4b
>> and HDMI 2.0.
>>
>> Features that are currently supported by the HDMI RX driver
>> have been tested on rock5b board using a HDMI to micro-HDMI cable.
>> It is recommended to use a good quality cable as there were
>> multiple issues seen during testing the driver.
>>
>> Please note the below information :-
>> * HDMIRX driver now only works with the opensource TF-A.
>> * We have tested the working of OBS studio with HDMIRX driver and
>> there were no issues seen.
>> * We tested and verified the support for interlaced video.
>> * We tested capturing of YUV formats.
>>
>> To test the HDMI RX Controller driver, following example commands can be used :-
>>
>> root at debian-rockchip-rock5b-rk3588:~# v4l2-ctl --verbose -d /dev/video0 \
>> --set-fmt-video=width=1920,height=1080,pixelformat='BGR3' --stream-mmap=4 \
>> --stream-skip=3 --stream-count=100 --stream-to=/home/hdmiin4k.raw --stream-poll
> 
> This looks a bit odd. This commandline should work just as well:
> 
> v4l2-ctl --stream-mmap --stream-count=100 --stream-to=/home/hdmiin4k.raw
> 
> v4l2-ctl will call QUERY_DV_TIMINGS, then (if a valid signal is found) S_DV_TIMINGS.
> That in turn updates the v4l2_format. So there is no need to set the video format,
> it should happen automatically.

Your cmdline works fine, setting format isn't necessary.

> Also, why skip the first three frames? And why select --stream-poll?
> 
> It could be that these are just left-overs from previous attempts, but it's
> weird.

It's indeed the left-overs, will edit the cover letter in v7.

> I also commented on the debugfs InfoFrame code in patch 4/6, that's not
> correct.

Thanks for the thorough review! :)

Additional note: I'm going to finish upstreaming of the driver because
Shreeya is currently busy. She will be maintaining driver afterwards.

-- 
Best regards,
Dmitry