[PATCH 1/8] arm64: dts: rockchip: fix i2c2 pinctrl-names property on anbernic-rg353p

Chris Morgan macromorgan at hotmail.com
Mon Sep 30 15:08:32 PDT 2024


On Mon, Sep 30, 2024 at 11:01:05PM +0200, Heiko Stuebner wrote:
> We want to control pins, not beer mugs, so rename pintctrl-names to the
> expected inctrl-names.

You may not want to control beer, but me...

Thank you for the catch, not sure how this first happened but
subsequent instances are likely a cut and paste.

Acked-by: Chris Morgan <macromorgan at hotmail.com>

> 
> This was not affecting functionality, because the i2c2 controller
> already had a set of pinctrl properties.
> 
> Fixes: 523adb553573 ("arm64: dts: rockchip: add Anbernic RG353P and RG503")
> Cc: Chris Morgan <macromorgan at hotmail.com>
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> index a73cf30801ec..9816a4ed4599 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts
> @@ -92,7 +92,7 @@ button-r2 {
>  };
>  
>  &i2c2 {
> -	pintctrl-names = "default";
> +	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c2m1_xfer>;
>  	status = "okay";
>  
> -- 
> 2.43.0
> 



More information about the Linux-rockchip mailing list