[PATCH] arm64: dts: rockchip: fix PCIe regulators for Radxa ROCK 3A

FUKAUMI Naoki naoki at radxa.com
Fri Sep 13 00:50:00 PDT 2024


hi,

On 9/13/24 16:02, Chukun Pan wrote:
>> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:656.32-664.5: ERROR
>> (duplicate_label): /pinctrl/pcie/pcie20m1-pins: Duplicate label
>> 'pcie20m1_pins' on /pinctrl/pcie/pcie20m1-pins and
>> /pinctrl/pcie20/pcie20m1-pins
>>
>> we need gpio pin for reset.

sorry, "U-Boot need gpio pin"

> Can't it work just written like this?
> 
> &pcie2x1 {
> 	pinctrl-names = "default";
> 	pinctrl-0 = <&pcie20m1_pins>;
> 	reset-gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_HIGH>;
> 	vpcie3v3-supply = <&vcc3v3_pcie>;
> 	status = "okay";
> };
> 
> If not, please overwrite the pinctrl:
> 
> 	pcie20 {
> 		pcie20m1_pins: pcie20m1-pins {

I didn't know how to overwrite it. thank you.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Thanks,
> Chukun
> 



More information about the Linux-rockchip mailing list