[PATCH] can: rockchip_canfd: avoids 64-bit division
Marc Kleine-Budde
mkl at pengutronix.de
Mon Sep 9 02:44:49 PDT 2024
On 09.09.2024 11:21:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
>
> The new driver fails to build on some 32-bit configurations:
>
> arm-linux-gnueabi-ld: drivers/net/can/rockchip/rockchip_canfd-timestamp.o: in function `rkcanfd_timestamp_init':
> rockchip_canfd-timestamp.c:(.text+0x14a): undefined reference to `__aeabi_ldivmod'
>
> Rework the delay calculation to only require a single 64-bit
> division.
>
> Fixes: 4e1a18bab124 ("can: rockchip_canfd: add hardware timestamping support")
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
I've already send a PR which replaces the division by div_u64(), so not
as elaborate as yours:
| https://lore.kernel.org/all/20240909-can-rockchip_canfd-fix-64-bit-division-v1-1-2748d9422b00@pengutronix.de/
I'll port your patch on top of mine and include it in my next PR.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20240909/02f98aeb/attachment.sig>
More information about the Linux-rockchip
mailing list