[PATCH 1/3] dt-bindings: vendor-prefixes: Add Shanghai Novotech Ariaboard

Junhao Xie bigfoot at classfun.cn
Wed Sep 4 22:22:14 PDT 2024


On 2024/9/4 21:29, Krzysztof Kozlowski wrote:
> On 04/09/2024 14:14, Junhao Xie wrote:
>> On 2024/9/4 19:35, Krzysztof Kozlowski wrote:
>>> On 04/09/2024 13:14, Junhao Xie wrote:
>>>> Add an entry for Shanghai Novotech Ariaboard (https://ariaboard.com/)
>>>>
>>>> Signed-off-by: Junhao Xie <bigfoot at classfun.cn>
>>>> ---
>>>>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>>>> index a70ce43b3dc0..58d1a2e8b212 100644
>>>> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>>>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>>>> @@ -145,6 +145,8 @@ patternProperties:
>>>>      description: Arctic Sand
>>>>    "^arcx,.*":
>>>>      description: arcx Inc. / Archronix Inc.
>>>> +  "^ariaboard,.*":
>>>> +    description: Shanghai Novotech Co., Ltd.
>>>
>>> This is confusing. Prefix is entirely different than company name. I
>>> would expect prefix like shanghainovotech.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Thank you for your reply.
>> Ariaboard is a subsidiary of Shanghai Novotech, maybe it would
>> be better to change description to "Ariaboard"?
>>
>> Shanghai Novotech: https://shanghainovotech.com/
>> Ariaboard: https://ariaboard.com/
> 
> This does not sound like subsidiary but just name of the board family or
> product family. Their about page suggests "affiliation" but all contact
> points are for Shanghai Novotech.
> 
> I am fine with ariaboard prefix, but please provide context in commit msg.
> 

Thanks, I will add it to commit message in PATCH v2.

Best regards,
Junhao



More information about the Linux-rockchip mailing list