[PATCH] arm64: dts: rockchip: use "pwm-leds" for multicolor PWM LEDs on Radxa E25

[FUKAUMI Naoki]

Hi,

On 8/16/24 21:25, Krzysztof Kozlowski wrote:
> On 16/08/2024 13:57, FUKAUMI Naoki wrote:
>> Hi,
>>
>> On 8/16/24 20:26, Heiko Stübner wrote:
>>> Am Freitag, 16. August 2024, 13:04:02 CEST schrieb FUKAUMI Naoki:
>>>> to make multicolor PWM LEDs behavior more consistent with vendor
>>>> kernel[1], use "pwm-leds" for it on Radxa E25.
>>>
>>> sorry, but that is definitly not a valid reason.
>>
>> I see. I'll not change it.
>>
>>> A devicetree does describe actual hardware and is not a space for
>>> configuration choices. So that whole notion to "match a kernel"
>>> is not correct.
>>>
>>> Looking at
>>> https://wiki.radxa.com/Rock3/CM/CM3I/E25/getting_started
>>> the specification table clearly designates the board's LED as
>>> "RGB LED" - so one LED and multicolor .
>>
>> I understand following behavior is not possible on mainline.
>>
>> https://github.com/radxa-pkg/rsetup/blob/main/config/00-rgb0-rainbow.conf
>>
>> this is not what we(Radxa) want, but we need to follow the rule.
>>
>> (btw wiki.radxa.com is outdated, it's not used anymore)
> 
> Your Radxa vendor kernel and whatever you have *MUST* align to the
> upstream, not the other way. The upstream is the correct source of doing
> things, not the other way.

could you tell me how to make rainbow color effect with 
"pwm-leds-multicolor" driver?

as far as I know, "pattern" trigger can change (only) brightness, not color.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Best regards,
> Krzysztof