[PATCH v6] rockchip/drm: vop2: add support for gamma LUT

Piotr Zalewski pZ010001011111 at proton.me
Tue Oct 29 02:48:02 PDT 2024


Hi Andy

> 在 2024-10-28 14:42:28,"Andy Yan" andyshrk at 163.com 写道:
> 
> > Hi Piotr,
> > Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a buildroot + weston environment:
> > weston --backend=drm-backend.so -i 0 --continue-without-input
> > weston-simple-egl
> > 
> > simple-egl will draw a triangle on the desktop.
> > After the patch applied,the triangle will flicker again and agian。
> > So it break some function。
> > I've been quite busy lately, and it will take some time before I can analyze what the specific reason is.
> 
> 
> Sorry, it's my fault. After more experiments, I found that the flickering I observed is not related to your patch.
> This should be a probability-related issue associated with alpha blending,which can be Fixed with patches in
> my series[0]
> [0] https://lore.kernel.org/linux-rockchip/75a13dbb.acb8.192289a8005.Coremail.andyshrk@163.com/#r

Np :)

> And for the gamma patch, I think there are still some small areas that can be improved.
> Please see my comment bellow:

Amended! thanks.

I will wait until weekend with next version, maybe there will be more
comments.



More information about the Linux-rockchip mailing list