[PATCH v3 7/7] arm64: dts: rockchip: Add GPU power domain regulator dependency for RK3588

Heiko Stübner heiko at sntech.de
Fri Oct 25 01:49:31 PDT 2024


Am Dienstag, 22. Oktober 2024, 17:41:52 CEST schrieb Sebastian Reichel:
> Enabling the GPU power domain requires that the GPU regulator is
> enabled. The regulator is enabled at boot time, but automatically
> gets disabled when there are no users.
> 
> If the GPU driver is not probed at boot time or rebound while
> the system is running the system will try to enable the power
> domain before the regulator is enabled resulting in a failure
> hanging the whole system. Avoid this by adding an explicit
> dependency.
> 
> Reported-by: Adrián Martínez Larumbe <adrian.larumbe at collabora.com>
> Tested-by: Adrian Larumbe <adrian.larumbe at collabora.com> # On Rock 5B
> Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.com>

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 8f7a59918db7..717504383d46 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -465,6 +465,10 @@ &pcie3x4 {
>  	status = "okay";
>  };
>  
> +&pd_gpu {
> +	domain-supply = <&vdd_gpu_s0>;
> +};
> +
>  &pinctrl {
>  	hdmirx {
>  		hdmirx_hpd: hdmirx-5v-detection {

nit: this seems to have seen some spillover from the not-yet-merged
hdmi-rx

Heiko





More information about the Linux-rockchip mailing list