[PATCH v2 04/14] arm64: dts: rockchip: Fix bluetooth properties on Rock960 boards

Dragan Simic dsimic at manjaro.org
Tue Oct 8 14:15:50 PDT 2024


Hello Heiko,

On 2024-10-08 22:39, Heiko Stuebner wrote:
> The expected clock-name is different, and extclk also is deprecated
> in favor of txco for clocks that are not crystals.
> 
> So fix it to match the binding.
> 
> Fixes: c72235c288c8 ("arm64: dts: rockchip: Add on-board WiFi/BT
> support for Rock960 boards")
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>

Looking good to me, thanks for the patch.  I've got this change
cross-referenced to what's expected in drivers/bluetooth/hci_bcm.c,
and it's fine.

Reviewed-by: Dragan Simic <dsimic at manjaro.org>

> ---
>  arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> index 8146f870d2bd..ab890e7b6c59 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> @@ -576,7 +576,7 @@ &uart0 {
>  	bluetooth {
>  		compatible = "brcm,bcm43438-bt";
>  		clocks = <&rk808 1>;
> -		clock-names = "ext_clock";
> +		clock-names = "txco";
>  		device-wakeup-gpios = <&gpio2 RK_PD3 GPIO_ACTIVE_HIGH>;
>  		host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>;
>  		shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;



More information about the Linux-rockchip mailing list