[PATCH v3 2/5] dt-bindings: ufs: Document Rockchip UFS host controller
Krzysztof Kozlowski
krzk at kernel.org
Tue Oct 8 06:32:14 PDT 2024
On Tue, Oct 08, 2024 at 02:15:27PM +0800, Shawn Lin wrote:
> Document Rockchip UFS host controller for RK3576 SoC.
>
> Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
>
> ---
>
> Changes in v3:
> - rename the file to rockchip,rk3576-ufshc.yaml
> - add description for reset-gpios
> - use rockchip,rk3576-ufshc as compatible
...
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 4
> +
> + reset-names:
> + items:
> + - const: biu
> + - const: sys
> + - const: ufs
> + - const: grf
> +
> + reset-gpios:
> + maxItems: 1
> + description: |
> + GPIO specifiers for host to reset the device.
Redundant description. I don't get why did you add it.... maybe we were
confused by duplicating resets and GPIO, but then say here something
useful not what the property name is already saying.
E.g. Which pin is this? Active low/high? Resets which device - phy?
memory?
With proper description:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Best regards,
Krzysztof
More information about the Linux-rockchip
mailing list