[PATCH] PCI: controller: Switch back to struct platform_driver::remove()
Uwe Kleine-König
u.kleine-koenig at baylibre.com
Thu Oct 3 03:17:08 PDT 2024
Hello,
I found this patch in next as 712359cb5e9d9553c1383fc5005593aa1988efc4.
While rebasing my patches with the same purpose I found that this patch
handled the indention differently than I did for two files:
On Mon, Sep 23, 2024 at 08:57:06AM +0200, Sergio Paracuellos wrote:
> diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
> index ef73baefaeb9..b921bbb4de80 100644
> --- a/drivers/pci/controller/pcie-altera.c
> +++ b/drivers/pci/controller/pcie-altera.c
> @@ -817,7 +817,7 @@ static void altera_pcie_remove(struct platform_device *pdev)
>
> static struct platform_driver altera_pcie_driver = {
> .probe = altera_pcie_probe,
> - .remove_new = altera_pcie_remove,
> + .remove = altera_pcie_remove,
> .driver = {
> .name = "altera-pcie",
> .of_match_table = altera_pcie_of_match,
here indention is inconsistent already before, I replaced the tabs after
".probe" by a single space (and after .remove, too).
> [...]
> diff --git a/drivers/pci/controller/pcie-hisi-error.c b/drivers/pci/controller/pcie-hisi-error.c
> index ad9d5ffcd9e3..cb5fcfe032d1 100644
> --- a/drivers/pci/controller/pcie-hisi-error.c
> +++ b/drivers/pci/controller/pcie-hisi-error.c
> @@ -317,7 +317,7 @@ static struct platform_driver hisi_pcie_error_handler_driver = {
> .acpi_match_table = hisi_pcie_acpi_match,
> },
> .probe = hisi_pcie_error_handler_probe,
> - .remove_new = hisi_pcie_error_handler_remove,
> + .remove = hisi_pcie_error_handler_remove,
> };
> module_platform_driver(hisi_pcie_error_handler_driver);
>
Here I added another tab after ".remove".
> [...]
Also the patch missed to adapt drivers/pci/controller/pcie-xilinx-nwl.c.
Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20241003/2bb1eedf/attachment.sig>
More information about the Linux-rockchip
mailing list